[PR #168] [CLOSED] fix: Fixing races and resouce leaks #237

New issue

Closed

opened 2026-02-28 14:26:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/168
Author: @tantra35
Created: 1/30/2025
Status: ❌ Closed

Base: master ← Head: fix-01-portion-of-sync-bugs

📄 Description

We must provide some cancelable context, so when main applplayer loop ends, any depend network operations must be canceled
When chanel is closed it return empty variables (in case none pointer it returns emptry structs, wil nil chanel and if we do ch recive o send "some data" to nil chanel we hang forever)
chanel for stop must be simple closed, in such case when we do <- closedCh we will signal in any case wneh chanel closed
Dealer must be closed at the end on player loop

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/168 **Author:** [@tantra35](https://github.com/tantra35) **Created:** 1/30/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-01-portion-of-sync-bugs` --- ### 📄 Description 1. We must provide some cancelable context, so when main applplayer loop ends, any depend network operations must be canceled 2. When chanel is closed it return empty variables (in case none pointer it returns emptry structs, wil nil chanel and if we do ch recive o send "some data" to nil chanel we hang forever) 3. chanel for stop must be simple closed, in such case when we do <- closedCh we will signal in any case wneh chanel closed 4. Dealer must be closed at the end on player loop --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>