[PR #164] [MERGED] feat: add ability to provide interface list to advertise throw zeroconf #236

New issue

Closed

opened 2026-02-28 14:26:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/164
Author: @tantra35
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @devgianlu

Base: master ← Head: fix-zerroconf

📝 Commits (5)

89c5517 add ability to provide interface list to advertise throw zeroconf
7c2bc11 1. rename advertise parameter interfaces_to_advertise -> zeroconf_interfaces_to_advertise
739f5c9 Merge remote-tracking branch 'upstream/master' into fix-zerroconf
9dbb226 docs: Fix typo
0475633 docs: fix typo

📊 Changes

4 files changed (+47 additions, -27 deletions)

View changed files

📝 README.md (+2 -0)
📝 cmd/daemon/main.go (+27 -25)
📝 config_schema.json (+5 -0)
📝 zeroconf/zeroconf.go (+13 -2)

📄 Description

Prior this PR, all interfaces that present in system are advertized, and this make a problem, bacause not all of them may be reachible throw localnetwork, for example docker intarface

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/164 **Author:** [@tantra35](https://github.com/tantra35) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-zerroconf` --- ### 📝 Commits (5) - [`89c5517`](https://github.com/devgianlu/go-librespot/commit/89c5517393e043f0594c3c74a2beb2b5873a97b0) add ability to provide interface list to advertise throw zeroconf - [`7c2bc11`](https://github.com/devgianlu/go-librespot/commit/7c2bc113fcb4ab6b01958e10e9091a27759540ea) 1. rename advertise parameter interfaces_to_advertise -> zeroconf_interfaces_to_advertise - [`739f5c9`](https://github.com/devgianlu/go-librespot/commit/739f5c9f8f3c8f99c9132f5ac6aa2d3771f3626b) Merge remote-tracking branch 'upstream/master' into fix-zerroconf - [`9dbb226`](https://github.com/devgianlu/go-librespot/commit/9dbb226cce4f285a3c89dd7a9717c58de35218f5) docs: Fix typo - [`0475633`](https://github.com/devgianlu/go-librespot/commit/04756336db68a8e176d32bb44f9fad8b4cb87beb) docs: fix typo ### 📊 Changes **4 files changed** (+47 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -0) 📝 `cmd/daemon/main.go` (+27 -25) 📝 `config_schema.json` (+5 -0) 📝 `zeroconf/zeroconf.go` (+13 -2) </details> ### 📄 Description Prior this PR, all interfaces that present in system are advertized, and this make a problem, bacause not all of them may be reachible throw localnetwork, for example docker intarface --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>