[PR #142] [CLOSED] API: Use prior volume updates as a reference for fast relative updates #230

New issue

Closed

opened 2026-02-28 14:26:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/142
Author: @2opremio
Created: 11/12/2024
Status: ❌ Closed

Base: master ← Head: use-local-vol-for-rel-changes

📝 Commits (1)

3b9c0e3 API: Use prior updates as a reference for fast relative updates

📊 Changes

1 file changed (+15 additions, -3 deletions)

View changed files

📝 cmd/daemon/player.go (+15 -3)

📄 Description

Fixes https://github.com/devgianlu/go-librespot/issues/141

I don't know if this is the best way to fix it, but what was happening is that the relative volume updates was using the player state which caused them to get stuck in the same value if they were more frequent than 1 second (the rate limited frequency with which Spotify is notified).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/142 **Author:** [@2opremio](https://github.com/2opremio) **Created:** 11/12/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `use-local-vol-for-rel-changes` --- ### 📝 Commits (1) - [`3b9c0e3`](https://github.com/devgianlu/go-librespot/commit/3b9c0e33eefd78825c194d493b0477196a0cd5b9) API: Use prior updates as a reference for fast relative updates ### 📊 Changes **1 file changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/player.go` (+15 -3) </details> ### 📄 Description Fixes https://github.com/devgianlu/go-librespot/issues/141 I don't know if this is the best way to fix it, but what was happening is that the relative volume updates was using the player state which caused them to get stuck in the same value if they were more frequent than 1 second (the rate limited frequency with which Spotify is notified). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>