[PR #138] [MERGED] fix: don't close ALSA output when pausing or on EOF #228

New issue

Closed

opened 2026-02-28 14:26:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/138
Author: @aykevl
Created: 11/9/2024
Status: ✅ Merged
Merged: 11/9/2024
Merged by: @devgianlu

Base: master ← Head: alsa-pause-on-return

📝 Commits (1)

e56abaa fix: don't close ALSA output when pausing or on EOF

📊 Changes

1 file changed (+20 additions, -11 deletions)

View changed files

📝 output/driver-alsa.go (+20 -11)

📄 Description

Previously the output would always be closed, even when calling Pause(). This worked for the most part, somehow, but not with recent changes.

Instead, only close the output when actually getting an ALSA error that can't be recovered from.

Did some quick testing and this seems to fix #135. Pause/resume seems to work, and autoplay seems to work as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/138 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 11/9/2024 **Status:** ✅ Merged **Merged:** 11/9/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `alsa-pause-on-return` --- ### 📝 Commits (1) - [`e56abaa`](https://github.com/devgianlu/go-librespot/commit/e56abaab6119c397776c44859d5edf472ac559f4) fix: don't close ALSA output when pausing or on EOF ### 📊 Changes **1 file changed** (+20 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `output/driver-alsa.go` (+20 -11) </details> ### 📄 Description Previously the output would always be closed, even when calling Pause(). This worked for the most part, somehow, but not with recent changes. Instead, only close the output when actually getting an ALSA error that can't be recovered from. --- Did some quick testing and this seems to fix #135. Pause/resume seems to work, and autoplay seems to work as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>