[PR #136] [CLOSED] Fix play/pause #226

New issue

Closed

opened 2026-02-28 14:26:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/136
Author: @devgianlu
Created: 11/8/2024
Status: ❌ Closed

Base: master ← Head: alsa-fix

📝 Commits (1)

99e82aa fix: do not leave alsa PCM handle dangling without active output loop

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 output/driver-alsa.go (+10 -2)

📄 Description

If the ALSA output loop exists with an EOF or an error the PCM handle will be left dangling. This implies that Resume() will not spin up a new output loop and nothing will be actually played.

I don't feel like this is the best fix, but it seems to work. @aykevl Can you have a look, what do you think would be the best approach here?

Fixes #135

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/136 **Author:** [@devgianlu](https://github.com/devgianlu) **Created:** 11/8/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `alsa-fix` --- ### 📝 Commits (1) - [`99e82aa`](https://github.com/devgianlu/go-librespot/commit/99e82aa5fdaf5d069c048df92d93f91ba88db5ba) fix: do not leave alsa PCM handle dangling without active output loop ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `output/driver-alsa.go` (+10 -2) </details> ### 📄 Description If the ALSA output loop exists with an EOF or an error the PCM handle will be left dangling. This implies that `Resume()` will not spin up a new output loop and nothing will be actually played. I don't feel like this is the best fix, but it seems to work. @aykevl Can you have a look, what do you think would be the best approach here? Fixes #135 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>