[PR #122] [MERGED] feat: don't seek when it's not needed #221

New issue

Closed

opened 2026-02-28 14:26:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/122
Author: @aykevl
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/12/2024
Merged by: @devgianlu

Base: master ← Head: feat-seek-if-needed

📝 Commits (1)

2addf8a feat: don't seek when it's not needed

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 player/player.go (+5 -2)

📄 Description

This seek takes around 0.5-1ms (when seeking to position 0) on a Raspberry Pi 3 which isn't much, but it's totally unnecessary in most cases so can be skipped.

This is basically the same as #116 but now as a very small performance improvement.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/122 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/12/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `feat-seek-if-needed` --- ### 📝 Commits (1) - [`2addf8a`](https://github.com/devgianlu/go-librespot/commit/2addf8a52344de8d443cfd9e1e5a8914949625f7) feat: don't seek when it's not needed ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `player/player.go` (+5 -2) </details> ### 📄 Description This seek takes around 0.5-1ms (when seeking to position 0) on a Raspberry Pi 3 which isn't much, but it's totally unnecessary in most cases so can be skipped. This is basically the same as #116 but now as a very small performance improvement. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>