[PR #112] [MERGED] fix: don't seek to the start when swiping right #215

New issue

Closed

opened 2026-02-28 14:26:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/112
Author: @aykevl
Created: 10/3/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @devgianlu

Base: master ← Head: fix-prev-without-seek

📝 Commits (1)

429194a fix: don't seek to the start when swiping right

📊 Changes

3 files changed (+5 additions, -4 deletions)

View changed files

📝 cmd/daemon/controls.go (+2 -2)
📝 cmd/daemon/player.go (+2 -2)
📝 dealer/recv.go (+1 -0)

📄 Description

The API has an extra parameter allow_seeking that indicates whether the seek left is due to pressing the "prev" button, or because the album is swiped right to go to the previous track immediately.

This patch adds support for this feature.

There's still one issue however: when going to the previous song, the player will for a short time show the first track in an album. ~~Not sure why, I suspect go-librespot doesn't send the whole queue (so the player doesn't know there are other tracks in the album).~~ see https://github.com/devgianlu/go-librespot/pull/113 for a fix to this bug.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/112 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 10/3/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix-prev-without-seek` --- ### 📝 Commits (1) - [`429194a`](https://github.com/devgianlu/go-librespot/commit/429194a65085ad908d8bf2976a999ffdfb13169b) fix: don't seek to the start when swiping right ### 📊 Changes **3 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/controls.go` (+2 -2) 📝 `cmd/daemon/player.go` (+2 -2) 📝 `dealer/recv.go` (+1 -0) </details> ### 📄 Description The API has an extra parameter `allow_seeking` that indicates whether the seek left is due to pressing the "prev" button, or because the album is swiped right to go to the previous track immediately. This patch adds support for this feature. There's still one issue however: when going to the previous song, the player will for a short time show the first track in an album. ~Not sure why, I suspect go-librespot doesn't send the whole queue (so the player doesn't know there are other tracks in the album).~ see https://github.com/devgianlu/go-librespot/pull/113 for a fix to this bug. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>