[PR #98] [CLOSED] fix: don't crash when to-be-prefetched track uri is empty #208

New issue

Closed

opened 2026-02-28 14:26:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/98
Author: @aykevl
Created: 9/19/2024
Status: ❌ Closed

Base: master ← Head: fix-prefetch-empty-uri

📝 Commits (1)

30ef184 fix: don't crash when to-be-prefetched track uri is empty

📊 Changes

2 files changed (+10 additions, -1 deletions)

View changed files

📝 cmd/daemon/controls.go (+8 -1)
📝 ids.go (+2 -0)

📄 Description

I'm not sure how to trigger this exactly. It happens when playing albums, and maybe has something to do with the web player and/or switching between players. But it does happen sometimes and just crashing isn't great.

I'm sure I've seen this working as intended (fetching the next track from the Gid field) but because it's hard to reproduce I'm not sure how to test this further. I will keep my debug code in place to see whether the new code path indeed works as expected and will report back if it does.

This fixes #97

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/98 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 9/19/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-prefetch-empty-uri` --- ### 📝 Commits (1) - [`30ef184`](https://github.com/devgianlu/go-librespot/commit/30ef18402a2e0ae55cd6f9057bca7b1fe743f196) fix: don't crash when to-be-prefetched track uri is empty ### 📊 Changes **2 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/controls.go` (+8 -1) 📝 `ids.go` (+2 -0) </details> ### 📄 Description I'm not sure how to trigger this exactly. It happens when playing albums, and maybe has something to do with the web player and/or switching between players. But it does happen sometimes and just crashing isn't great. I'm sure I've seen this working as intended (fetching the next track from the `Gid` field) but because it's hard to reproduce I'm not sure how to test this further. I will keep my debug code in place to see whether the new code path indeed works as expected and will report back if it does. This fixes #97 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>