[PR #102] [MERGED] fix: retry PutConnectState on error, check ContentLength to avoid EOF error #206

New issue

Closed

opened 2026-02-28 14:26:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/102
Author: @kenny59
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/29/2024
Merged by: @devgianlu

Base: master ← Head: fix/spclient_putconnectstate_500

📝 Commits (4)

423d091 fix: retry PutConnectState on error, check ContentLength to avoid EOF error
de4cbdc Merge branch 'devgianlu:master' into fix/spclient_putconnectstate_500
9fa5ad9 Merge branch 'devgianlu:master' into fix/spclient_putconnectstate_500
b01b41f fix: remove redundant check for ContentLength <= 0 and revert log messages to original value

📊 Changes

1 file changed (+31 additions, -25 deletions)

View changed files

📝 spclient/spclient.go (+31 -25)

📄 Description

I was getting 500 status with empty body randomly throughout the day when PutConnectState was called.
Have tested for a day or so and I am not getting EOF errors anymore.

Commit does:
Retrying the request (not sure how important that method is for the app to run properly) and checking ContentLength so we are not getting EOF errors during decoding JSON.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/102 **Author:** [@kenny59](https://github.com/kenny59) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/29/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `fix/spclient_putconnectstate_500` --- ### 📝 Commits (4) - [`423d091`](https://github.com/devgianlu/go-librespot/commit/423d0915412359b5a0ed54de38b692ee84863256) fix: retry PutConnectState on error, check ContentLength to avoid EOF error - [`de4cbdc`](https://github.com/devgianlu/go-librespot/commit/de4cbdc1d919dbe25aba86954c0614622853f7b6) Merge branch 'devgianlu:master' into fix/spclient_putconnectstate_500 - [`9fa5ad9`](https://github.com/devgianlu/go-librespot/commit/9fa5ad9c1c441f51e8c2137938bab325aaede6c2) Merge branch 'devgianlu:master' into fix/spclient_putconnectstate_500 - [`b01b41f`](https://github.com/devgianlu/go-librespot/commit/b01b41f1300e3da3b2c6ba6513c9a6f0b1decc6d) fix: remove redundant check for ContentLength <= 0 and revert log messages to original value ### 📊 Changes **1 file changed** (+31 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `spclient/spclient.go` (+31 -25) </details> ### 📄 Description I was getting 500 status with empty body randomly throughout the day when PutConnectState was called. Have tested for a day or so and I am not getting EOF errors anymore. Commit does: Retrying the request (not sure how important that method is for the app to run properly) and checking ContentLength so we are not getting EOF errors during decoding JSON. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>