[PR #83] [MERGED] Default configuration file #198

Closed
opened 2026-02-28 14:26:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/83
Author: @aykevl
Created: 9/8/2024
Status: Merged
Merged: 9/10/2024
Merged by: @devgianlu

Base: masterHead: default-config


📝 Commits (3)

  • 2bfa72a feat: do no exit with error when config file is not set
  • 076447b feat: default to zeroconf credentials
  • 3acb25c feat: add hostname to default device name

📊 Changes

1 file changed (+16 additions, -3 deletions)

View changed files

📝 cmd/daemon/main.go (+16 -3)

📄 Description

Instead of failing altogether, this PR falls back to a default configuration file if -config_path is not set.
The default configuration file would be the equivalent of:

device_name: go-librespot <hostname>
credentials:
  type: zeroconf

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/83 **Author:** [@aykevl](https://github.com/aykevl) **Created:** 9/8/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `default-config` --- ### 📝 Commits (3) - [`2bfa72a`](https://github.com/devgianlu/go-librespot/commit/2bfa72a4c99a873ec5844c72d11c8eda5e58f2d4) feat: do no exit with error when config file is not set - [`076447b`](https://github.com/devgianlu/go-librespot/commit/076447b7a46c9ff2d5fc463f6f014a5911220ed8) feat: default to zeroconf credentials - [`3acb25c`](https://github.com/devgianlu/go-librespot/commit/3acb25ccebc892d9be7f91475ed6b42fef1d1846) feat: add hostname to default device name ### 📊 Changes **1 file changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/main.go` (+16 -3) </details> ### 📄 Description Instead of failing altogether, this PR falls back to a default configuration file if `-config_path` is not set. The default configuration file would be the equivalent of: ```yaml device_name: go-librespot <hostname> credentials: type: zeroconf ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:26:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-librespot#198
No description provided.