[PR #66] [MERGED] add web-api passthrough #187

New issue

Closed

opened 2026-02-28 14:26:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:26:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/go-librespot/pull/66
Author: @preampinbut
Created: 8/16/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @devgianlu

Base: master ← Head: master

📝 Commits (10+)

5302ea8 add web-api passthrough
8bb2e27 fix comment
8e68ced add error log like in the original
c58284e following naming convention
29ccde0 move Body.Close below error condition
4177119 fix and update statuscode
36d23ee refactor: spclient request
31a7b8f add type ApiResponseMessage
7c983af convert response message into ApiResponseMessage
b3ebe55 chore: cleanup

📊 Changes

4 files changed (+122 additions, -12 deletions)

View changed files

📝 cmd/daemon/api_server.go (+58 -10)
📝 cmd/daemon/player.go (+42 -0)
📝 session/getters.go (+7 -0)
📝 spclient/spclient.go (+15 -2)

📄 Description

I know this may not looking good but it is what it is from what I see web api have no other header request except authorization no? so I didn't make header passthrough

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/go-librespot/pull/66 **Author:** [@preampinbut](https://github.com/preampinbut) **Created:** 8/16/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`5302ea8`](https://github.com/devgianlu/go-librespot/commit/5302ea818e0d1785bba5cfd1fed0bb73f0cc6ccc) add web-api passthrough - [`8bb2e27`](https://github.com/devgianlu/go-librespot/commit/8bb2e27fc056f23f6d26c71759c06e405a78d8f5) fix comment - [`8e68ced`](https://github.com/devgianlu/go-librespot/commit/8e68ced46d91f76d3df59f19d0cf34864a1ad20e) add error log like in the original - [`c58284e`](https://github.com/devgianlu/go-librespot/commit/c58284ef4e9411267e833143df3dcdb17581dfe4) following naming convention - [`29ccde0`](https://github.com/devgianlu/go-librespot/commit/29ccde0cab8ff6ead2e4d89ba49b4529baeb96a1) move Body.Close below error condition - [`4177119`](https://github.com/devgianlu/go-librespot/commit/4177119efac10a32017999ed8002fc2b9d585526) fix and update statuscode - [`36d23ee`](https://github.com/devgianlu/go-librespot/commit/36d23ee24bb55bae22af05fb83a87b184ea196f7) refactor: spclient request - [`31a7b8f`](https://github.com/devgianlu/go-librespot/commit/31a7b8f7204925b2ea0f31178876108a22f8fc7f) add type ApiResponseMessage - [`7c983af`](https://github.com/devgianlu/go-librespot/commit/7c983af32bc90115db6db278f69c09330b238ee4) convert response message into ApiResponseMessage - [`b3ebe55`](https://github.com/devgianlu/go-librespot/commit/b3ebe55bc2ec0428db098dea0128c9a4099a40cc) chore: cleanup ### 📊 Changes **4 files changed** (+122 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `cmd/daemon/api_server.go` (+58 -10) 📝 `cmd/daemon/player.go` (+42 -0) 📝 `session/getters.go` (+7 -0) 📝 `spclient/spclient.go` (+15 -2) </details> ### 📄 Description I know this may not looking good but it is what it is from what I see web api have no other header request except authorization no? so I didn't make header passthrough ![Sat Aug 17 12:54:22 AM +07 2024](https://github.com/user-attachments/assets/44b0827d-728e-4ab4-955d-2d7fb94b9923) ![Sat Aug 17 12:55:16 AM +07 2024](https://github.com/user-attachments/assets/d2b6f2d3-070f-42c7-9069-ed231ec61ce6) ![Sat Aug 17 12:55:41 AM +07 2024](https://github.com/user-attachments/assets/dca243ed-8e92-4138-9dd6-ee870cf6a216) ![Sat Aug 17 01:12:59 AM +07 2024](https://github.com/user-attachments/assets/78135d61-69af-4ad3-a945-12afb3b3b7d0) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>