starred/go-backend-clean-architecture
1
0
Fork 0
mirror of https://github.com/amitshekhariitbhu/go-backend-clean-architecture.git synced 2026-04-27 05:25:51 +03:00
Code Issues 19 Projects Releases Packages Wiki Activity

[GH-ISSUE #8] Declouple Controller from MongoDB #6

New issue
Open
opened 2026-03-01 14:36:45 +03:00 by kerem · 3 comments
kerem commented 2026-03-01 14:36:45 +03:00
Owner
Copy link

Originally created by @marcosvidolin on GitHub (Jan 19, 2023).
Original GitHub issue: https://github.com/amitshekhariitbhu/go-backend-clean-architecture/issues/8

Hi,

We have a MongoDB dependency in the controller. You can see here: https://github.com/amitshekhariitbhu/go-backend-clean-architecture/blob/main/api/controller/task_controller.go#L8
Maybe we should consider move the code bellow to other layer:

task.ID = primitive.NewObjectID()
task.UserID, err = primitive.ObjectIDFromHex(userID)

What's your thoughts?

Originally created by @marcosvidolin on GitHub (Jan 19, 2023). Original GitHub issue: https://github.com/amitshekhariitbhu/go-backend-clean-architecture/issues/8 Hi, We have a MongoDB dependency in the controller. You can see here: https://github.com/amitshekhariitbhu/go-backend-clean-architecture/blob/main/api/controller/task_controller.go#L8 Maybe we should consider move the code bellow to other layer: ```go task.ID = primitive.NewObjectID() task.UserID, err = primitive.ObjectIDFromHex(userID) ``` What's your thoughts?
kerem commented 2026-03-01 14:36:46 +03:00
Author
Owner
Copy link

@amitshekhariitbhu commented on GitHub (Jan 19, 2023):

Hi @marcosvidolin

Your point is valid. A few more developers also suggested making this change. I shall do it.

Thanks

<!-- gh-comment-id:1397010311 --> @amitshekhariitbhu commented on GitHub (Jan 19, 2023): Hi @marcosvidolin Your point is valid. A few more developers also suggested making this change. I shall do it. Thanks
kerem commented 2026-03-01 14:36:46 +03:00
Author
Owner
Copy link

@ZeusMode commented on GitHub (Aug 24, 2023):

Hi @marcosvidolin

I understood your suggestion but makes me wonder how can we properly handle errors like this to not be generic InternalServerError?

Sorry for the late response here, I just found this project

<!-- gh-comment-id:1692171254 --> @ZeusMode commented on GitHub (Aug 24, 2023): Hi @marcosvidolin I understood your suggestion but makes me wonder how can we properly handle errors like this to not be generic InternalServerError? Sorry for the late response here, I just found this project
kerem commented 2026-03-01 14:36:46 +03:00
Author
Owner
Copy link

@marcosvidolin commented on GitHub (Aug 29, 2023):

I would recommend moving this code to the MongoDB repository and also suggest creating a custom error in the following manner:

task, err := primitive.ObjectIDFromHex(userID)
if err != nil {
    return nil, ErrMyCustonIDGeneration("error message") // change the error name ;)
}
<!-- gh-comment-id:1697941269 --> @marcosvidolin commented on GitHub (Aug 29, 2023): > I would recommend moving this code to the MongoDB repository and also suggest creating a custom error in the following manner: ```go task, err := primitive.ObjectIDFromHex(userID) if err != nil { return nil, ErrMyCustonIDGeneration("error message") // change the error name ;) } ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/go-backend-clean-architecture#6
No description provided.