mirror of
https://github.com/thegeeklab/git-sv.git
synced 2026-04-25 02:05:51 +03:00
[GH-ISSUE #117] Set update-major to "breaking" by default? #2
Labels
No labels
bug
documentation
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/git-sv#2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pat-s on GitHub (Oct 18, 2024).
Original GitHub issue: https://github.com/thegeeklab/git-sv/issues/117
Wondering why the default is empty but at the same time there is a release-section that processes breaking changes by also hasn't any
commit-typeassigned?@xoxys commented on GitHub (Oct 20, 2024):
Breaking changes are detected by two mechanisms:
BREAKING CHANGEstring in commit message body!suffix, e.g.feat!Major version bumps are always performed if the history contains any breaking changes detected by one of the mechanisms described above. The
versioning.update-majorconfig option is intended to bump major versions on other commit types, e.g.versioning.update-major: [refactor]to bump the major version also on all refactor commits.What you are asking for is a default configuration to tread commit messages like
breaking: this commit breaks everythingas a breaking change by default?@pat-s commented on GitHub (Oct 21, 2024):
Ah yes, my bad. Fully compliant with conv commits (sorry, never had to use a breaking commit so far since applying conv commits). Intuitively I thought about the
breaking:prefix but I see that not having that prefix defined is more accurate.Yes but users can do so anyway in their config then. I guess sticking with conv commit defaults is the best approach.