[PR #487] Revert pwsh preference for Windows upgrades #510

New issue

Closed

opened 2026-03-02 04:13:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:13:49 +03:00

Owner

Original Pull Request: https://github.com/git-ai-project/git-ai/pull/487

State: closed
Merged: Yes

Motivation

Simplify Windows upgrade behavior by reverting the pwsh-first spawn logic because the PowerShell checksum fallback implemented in install.ps1 removes the need to prefer pwsh.

Description

Remove the spawn_powershell closure that tried pwsh then powershell and instead invoke powershell directly via Command::new("powershell") while keeping -NoProfile, -ExecutionPolicy Bypass, -Command, CREATE_NO_WINDOW, the GIT_AI_RELEASE_ENV env var, and the silent stdout/stderr behavior.

Testing

No automated tests were run as part of this change (CI/integration validation is expected to run in workflows).

Codex Task

**Original Pull Request:** https://github.com/git-ai-project/git-ai/pull/487 **State:** closed **Merged:** Yes --- ### Motivation - Simplify Windows upgrade behavior by reverting the pwsh-first spawn logic because the PowerShell checksum fallback implemented in `install.ps1` removes the need to prefer `pwsh`. ### Description - Remove the `spawn_powershell` closure that tried `pwsh` then `powershell` and instead invoke `powershell` directly via `Command::new("powershell")` while keeping `-NoProfile`, `-ExecutionPolicy Bypass`, `-Command`, `CREATE_NO_WINDOW`, the `GIT_AI_RELEASE_ENV` env var, and the silent `stdout`/`stderr` behavior. ### Testing - No automated tests were run as part of this change (CI/integration validation is expected to run in workflows). ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_6988bfee2060832cacedd646d620ee40)  --- <a href="https://app.devin.ai/review/git-ai-project/git-ai/pull/487" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>