[PR #485] Wait for Windows upgrade completion in nightly workflow #507

New issue

Closed

opened 2026-03-02 04:13:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:13:49 +03:00

Owner

Original Pull Request: https://github.com/git-ai-project/git-ai/pull/485

State: closed
Merged: Yes

Motivation

Windows installers run the upgrade in the background and the in-use binary can take a moment to be replaced, so an immediate version comparison can produce a false failure.
The workflow already normalizes v-prefixed tags and uses a PowerShell here-string to run the Python selection script, and the Windows job needs a complementary wait to be reliable.

Description

Updated .github/workflows/nightly-upgrade.yml Windows job to poll the installed version after running install.ps1 and git-ai upgrade until it matches the expected latest or a 3-minute deadline is reached.
The loop sleeps 5 seconds between checks and both latest and installed are compared after trimming any leading v using .TrimStart('v'), and the step throws "Expected $latest after upgrade, got $installed" on timeout.
No changes were made to the non-Windows install/upgrade flow; Linux/macOS behavior and the version-selection logic remain unchanged.

Testing

No automated workflows were executed after this change, so CI validation is pending.
Trigger the workflow via workflow_dispatch or wait for the scheduled run to validate the Windows upgrade polling logic on windows-latest.

Codex Task

**Original Pull Request:** https://github.com/git-ai-project/git-ai/pull/485 **State:** closed **Merged:** Yes --- ### Motivation - Windows installers run the upgrade in the background and the in-use binary can take a moment to be replaced, so an immediate version comparison can produce a false failure. - The workflow already normalizes `v`-prefixed tags and uses a PowerShell here-string to run the Python selection script, and the Windows job needs a complementary wait to be reliable. ### Description - Updated `.github/workflows/nightly-upgrade.yml` Windows job to poll the installed version after running `install.ps1` and `git-ai upgrade` until it matches the expected `latest` or a 3-minute deadline is reached. - The loop sleeps 5 seconds between checks and both `latest` and `installed` are compared after trimming any leading `v` using `.TrimStart('v')`, and the step throws `"Expected $latest after upgrade, got $installed"` on timeout. - No changes were made to the non-Windows install/upgrade flow; Linux/macOS behavior and the version-selection logic remain unchanged. ### Testing - No automated workflows were executed after this change, so CI validation is pending. - Trigger the workflow via `workflow_dispatch` or wait for the scheduled run to validate the Windows upgrade polling logic on `windows-latest`. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_6988bfee2060832cacedd646d620ee40)  --- <a href="https://app.devin.ai/review/git-ai-project/git-ai/pull/485" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>