[PR #483] Nightly upgrade workflow: restrict tested releases to >= v1.0.26 #504

New issue

Closed

opened 2026-03-02 04:13:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:13:49 +03:00

Owner

Original Pull Request: https://github.com/git-ai-project/git-ai/pull/483

State: closed
Merged: Yes

Motivation

Prevent the nightly upgrade job from selecting releases older than v1.0.26 which predate the git-ai upgrade command and cause spurious failures.
Avoid brittle runtime git invocations in the embedded Python that previously failed with "No semver tags found for upgrade command" in the runner environment.
Maintain cross-platform validation across Linux, macOS, and Windows by keeping separate selection scripts for each runner.

Description

Added/updated .github/workflows/nightly-upgrade.yml to fetch tags (fetch-tags: true) and implement version selection in embedded Python for non-Windows and Windows runners.
Replaced the previous dynamic git-based detection with a fixed minimum floor min_upgrade_tuple = (1, 0, 26) in both Python blocks to ensure no releases older than v1.0.26 are selected.
Removed use of subprocess in the embedded scripts and made the workflow export latest, min_upgrade, and sampled versions via GITHUB_OUTPUT for visibility.
Added install-and-upgrade steps for non-Windows and Windows that install sampled older releases and run git-ai upgrade to verify the upgrade path reaches the latest tag.

Testing

No automated tests were executed for this workflow change; validation requires triggering the workflow via workflow_dispatch or awaiting the scheduled run.
The change is limited to CI workflow configuration and did not run any unit or integration tests in this PR.

Codex Task

**Original Pull Request:** https://github.com/git-ai-project/git-ai/pull/483 **State:** closed **Merged:** Yes --- ### Motivation - Prevent the nightly upgrade job from selecting releases older than `v1.0.26` which predate the `git-ai upgrade` command and cause spurious failures. - Avoid brittle runtime `git` invocations in the embedded Python that previously failed with "No semver tags found for upgrade command" in the runner environment. - Maintain cross-platform validation across Linux, macOS, and Windows by keeping separate selection scripts for each runner. ### Description - Added/updated `.github/workflows/nightly-upgrade.yml` to fetch tags (`fetch-tags: true`) and implement version selection in embedded Python for non-Windows and Windows runners. - Replaced the previous dynamic `git`-based detection with a fixed minimum floor `min_upgrade_tuple = (1, 0, 26)` in both Python blocks to ensure no releases older than `v1.0.26` are selected. - Removed use of `subprocess` in the embedded scripts and made the workflow export `latest`, `min_upgrade`, and sampled `versions` via `GITHUB_OUTPUT` for visibility. - Added install-and-upgrade steps for non-Windows and Windows that install sampled older releases and run `git-ai upgrade` to verify the upgrade path reaches the `latest` tag. ### Testing - No automated tests were executed for this workflow change; validation requires triggering the workflow via `workflow_dispatch` or awaiting the scheduled run. - The change is limited to CI workflow configuration and did not run any unit or integration tests in this PR. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_6988bfee2060832cacedd646d620ee40)  --- <a href="https://app.devin.ai/review/git-ai-project/git-ai/pull/483" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>