clippy` #486

New issue

Closed

opened 2026-03-02 04:13:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 04:13:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/git-ai-project/git-ai/pull/455
Author: @jwiegley
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @svarlamov

Base: main ← Head: johnw/clean-warnings

📝 Commits (10+)

d3424cb Clean all compiler, clippy, and Rust 1.93.0 warnings in library source
1d1dc80 Clean all compiler, clippy, and test warnings in test files
716008c Fix test binary path to respect CARGO_TARGET_DIR
fcd843d Fix all cargo doc warnings by escaping angle brackets in doc comments
8bcb1d4 Apply suggestion from @devin-ai-integration[bot]
1cd33c5 apply devin suggestion
d545b7f fix regex test
8653e0e Remove unused imports
0937257 Remove unused variable assignment
5788712 Remove unused default_prompt_storage accessor

📊 Changes

102 files changed (+1188 additions, -1319 deletions)

View changed files

📝 src/api/bundle.rs (+1 -1)
📝 src/api/cas.rs (+1 -1)
📝 src/api/client.rs (+4 -1)
📝 src/api/metrics.rs (+2 -1)
📝 src/api/mod.rs (+1 -1)
📝 src/auth/credentials.rs (+1 -0)
📝 src/auth/mod.rs (+0 -2)
📝 src/auth/types.rs (+1 -0)
📝 src/authorship/attribution_tracker.rs (+23 -24)
📝 src/authorship/authorship_log.rs (+2 -2)
📝 src/authorship/authorship_log_serialization.rs (+11 -13)
📝 src/authorship/diff_ai_accepted.rs (+5 -3)
📝 src/authorship/imara_diff_utils.rs (+0 -2)
📝 src/authorship/post_commit.rs (+10 -15)
📝 src/authorship/prompt_utils.rs (+5 -6)
📝 src/authorship/range_authorship.rs (+14 -17)
📝 src/authorship/rebase_authorship.rs (+11 -19)
📝 src/authorship/secrets.rs (+4 -2)
📝 src/authorship/stats.rs (+22 -39)
📝 src/authorship/transcript.rs (+2 -0)

...and 80 more files

📄 Description

This was done against:

rustc 1.93.0 (254b59607 2026-01-19)
cargo 1.93.0 (083ac5135 2025-12-15)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/git-ai-project/git-ai/pull/455 **Author:** [@jwiegley](https://github.com/jwiegley) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@svarlamov](https://github.com/svarlamov) **Base:** `main` ← **Head:** `johnw/clean-warnings` --- ### 📝 Commits (10+) - [`d3424cb`](https://github.com/git-ai-project/git-ai/commit/d3424cb0363ec95d6647ebde5f17607e373fcab5) Clean all compiler, clippy, and Rust 1.93.0 warnings in library source - [`1d1dc80`](https://github.com/git-ai-project/git-ai/commit/1d1dc8097ef8a0c3c931de0eee3257697f96be4d) Clean all compiler, clippy, and test warnings in test files - [`716008c`](https://github.com/git-ai-project/git-ai/commit/716008c5fde96e8a70878be70e7535aa92899b0d) Fix test binary path to respect CARGO_TARGET_DIR - [`fcd843d`](https://github.com/git-ai-project/git-ai/commit/fcd843d307df3a0493634af02e0ddacb8916676f) Fix all cargo doc warnings by escaping angle brackets in doc comments - [`8bcb1d4`](https://github.com/git-ai-project/git-ai/commit/8bcb1d4717db8064ce203ce0f655242a383abdbf) Apply suggestion from @devin-ai-integration[bot] - [`1cd33c5`](https://github.com/git-ai-project/git-ai/commit/1cd33c5b3bd8ffceb1618668d96fc55fb594b0de) apply devin suggestion - [`d545b7f`](https://github.com/git-ai-project/git-ai/commit/d545b7f65725b3ff04f44a0cd89640dea17556bc) fix regex test - [`8653e0e`](https://github.com/git-ai-project/git-ai/commit/8653e0eada82217c90ad58b94b29856c9ea52572) Remove unused imports - [`0937257`](https://github.com/git-ai-project/git-ai/commit/0937257fd7c5fbddcfc55d4bd9508df8e9d37341) Remove unused variable assignment - [`5788712`](https://github.com/git-ai-project/git-ai/commit/5788712ed80f304792a44e449a31f5332feb7787) Remove unused default_prompt_storage accessor ### 📊 Changes **102 files changed** (+1188 additions, -1319 deletions) <details> <summary>View changed files</summary> 📝 `src/api/bundle.rs` (+1 -1) 📝 `src/api/cas.rs` (+1 -1) 📝 `src/api/client.rs` (+4 -1) 📝 `src/api/metrics.rs` (+2 -1) 📝 `src/api/mod.rs` (+1 -1) 📝 `src/auth/credentials.rs` (+1 -0) 📝 `src/auth/mod.rs` (+0 -2) 📝 `src/auth/types.rs` (+1 -0) 📝 `src/authorship/attribution_tracker.rs` (+23 -24) 📝 `src/authorship/authorship_log.rs` (+2 -2) 📝 `src/authorship/authorship_log_serialization.rs` (+11 -13) 📝 `src/authorship/diff_ai_accepted.rs` (+5 -3) 📝 `src/authorship/imara_diff_utils.rs` (+0 -2) 📝 `src/authorship/post_commit.rs` (+10 -15) 📝 `src/authorship/prompt_utils.rs` (+5 -6) 📝 `src/authorship/range_authorship.rs` (+14 -17) 📝 `src/authorship/rebase_authorship.rs` (+11 -19) 📝 `src/authorship/secrets.rs` (+4 -2) 📝 `src/authorship/stats.rs` (+22 -39) 📝 `src/authorship/transcript.rs` (+2 -0) _...and 80 more files_ </details> ### 📄 Description This was done against: ``` rustc 1.93.0 (254b59607 2026-01-19) cargo 1.93.0 (083ac5135 2025-12-15) ```  --- <a href="https://app.devin.ai/review/git-ai-project/git-ai/pull/455" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>