[GH-ISSUE #59] HEAD doesn't build with abh/go-metrics #45

Closed
opened 2026-02-28 14:16:02 +03:00 by kerem · 5 comments
Owner

Originally created by @leifj on GitHub (Nov 25, 2014).
Original GitHub issue: https://github.com/abh/geodns/issues/59

./metrics.go:26: cannot use metrics.NewHistogram(metrics.NewUniformSample(1800)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion
./metrics.go:29: cannot use metrics.NewHistogram(metrics.NewExpDecaySample(600, 0.015)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion
./metrics.go:32: cannot use metrics.NewGauge() (type metrics.Gauge) as type *metrics.StandardGauge in assignment: need type assertion
./zone.go:85: cannot use metrics.NewMeter() (type metrics.Meter) as type *metrics.StandardMeter in assignment: need type assertion

Originally created by @leifj on GitHub (Nov 25, 2014). Original GitHub issue: https://github.com/abh/geodns/issues/59 ./metrics.go:26: cannot use metrics.NewHistogram(metrics.NewUniformSample(1800)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion ./metrics.go:29: cannot use metrics.NewHistogram(metrics.NewExpDecaySample(600, 0.015)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion ./metrics.go:32: cannot use metrics.NewGauge() (type metrics.Gauge) as type *metrics.StandardGauge in assignment: need type assertion ./zone.go:85: cannot use metrics.NewMeter() (type metrics.Meter) as type *metrics.StandardMeter in assignment: need type assertion
kerem closed this issue 2026-02-28 14:16:03 +03:00
Author
Owner

@leifj commented on GitHub (Nov 25, 2014):

This is go1.2.1 btw

<!-- gh-comment-id:64411537 --> @leifj commented on GitHub (Nov 25, 2014): This is go1.2.1 btw
Author
Owner

@leifj commented on GitHub (Nov 25, 2014):

actually I think I'm wrong. I was looking at a local branch

<!-- gh-comment-id:64413111 --> @leifj commented on GitHub (Nov 25, 2014): actually I think I'm wrong. I was looking at a local branch
Author
Owner

@abh commented on GitHub (Nov 25, 2014):

I think what you are saying is that I should make a godep file. :-)

<!-- gh-comment-id:64418895 --> @abh commented on GitHub (Nov 25, 2014): I think what you are saying is that I should make a godep file. :-)
Author
Owner

@leifj commented on GitHub (Nov 25, 2014):

On 2014-11-25 16:41, Ask Bjørn Hansen wrote:

I think what you are saying is that I should make a godep file. :-)


Reply to this email directly or view it on GitHub
https://github.com/abh/geodns/issues/59#issuecomment-64418895.

yeah maybe :-)

<!-- gh-comment-id:64486910 --> @leifj commented on GitHub (Nov 25, 2014): On 2014-11-25 16:41, Ask Bjørn Hansen wrote: > I think what you are saying is that I should make a godep file. :-) > > — > Reply to this email directly or view it on GitHub > https://github.com/abh/geodns/issues/59#issuecomment-64418895. > > yeah maybe :-)
Author
Owner

@abh commented on GitHub (Nov 26, 2014):

Looks like I started on that in

commit 24ce842203
Author: Ask Bjørn Hansen
Date: Sun Oct 19 15:03:32 2014 -0700

Use godep to track dependencies

:-)

<!-- gh-comment-id:64509755 --> @abh commented on GitHub (Nov 26, 2014): Looks like I started on that in commit 24ce842203c348e4b30eff00819a5f6384bb5235 Author: Ask Bjørn Hansen Date: Sun Oct 19 15:03:32 2014 -0700 ``` Use godep to track dependencies ``` :-)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/geodns#45
No description provided.