[PR #91] [CLOSED] Add delay to test start. #413

New issue

Closed

opened 2026-03-13 14:52:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 14:52:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/91
Author: @abligh
Created: 3/4/2016
Status: ❌ Closed

Base: master ← Head: add-delay-to-test-start

📝 Commits (1)

cc09d9d Add delay to test start.

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 serve_test.go (+4 -0)

📄 Description

Commit c86fbed741 tidied some things
up but also removed a 200ms delay. This appears to be necessary to
ensure the server has actually started before sending it queries.
This is causing some random failures on travis builds I think.

Signed-off-by: Alex Bligh alex@alex.org.uk

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/91 **Author:** [@abligh](https://github.com/abligh) **Created:** 3/4/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-delay-to-test-start` --- ### 📝 Commits (1) - [`cc09d9d`](https://github.com/abh/geodns/commit/cc09d9d9917f030ed6f58df602fb03667e5e73b1) Add delay to test start. ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `serve_test.go` (+4 -0) </details> ### 📄 Description Commit c86fbed741f51c20f4fd16b927f67cf82368869f tidied some things up but also removed a 200ms delay. This appears to be necessary to ensure the server has actually started before sending it queries. This is causing some random failures on travis builds I think. Signed-off-by: Alex Bligh alex@alex.org.uk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>