[PR #76] [MERGED] Fix race referencing config #406

Closed
opened 2026-03-13 14:51:29 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/76
Author: @abligh
Created: 8/31/2015
Status: Merged
Merged: 9/3/2015
Merged by: @abh

Base: masterHead: fix-config-race


📝 Commits (1)

  • 75f2193 Fix race referencing config

📊 Changes

4 files changed (+35 additions, -12 deletions)

View changed files

📝 config.go (+23 -1)
📝 geodns.go (+2 -2)
📝 geoip.go (+3 -2)
📝 stathat.go (+7 -7)

📄 Description

Three data races existed referencing the Config item - these
can be detected by running after building with 'go build -race'
on go 1.4.2. This fixes them by adding an RWMutex to protect
the config structure.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/76 **Author:** [@abligh](https://github.com/abligh) **Created:** 8/31/2015 **Status:** ✅ Merged **Merged:** 9/3/2015 **Merged by:** [@abh](https://github.com/abh) **Base:** `master` ← **Head:** `fix-config-race` --- ### 📝 Commits (1) - [`75f2193`](https://github.com/abh/geodns/commit/75f21937fb32dd445ddc8d856c5832fa434dc0ec) Fix race referencing config ### 📊 Changes **4 files changed** (+35 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `config.go` (+23 -1) 📝 `geodns.go` (+2 -2) 📝 `geoip.go` (+3 -2) 📝 `stathat.go` (+7 -7) </details> ### 📄 Description Three data races existed referencing the Config item - these can be detected by running after building with 'go build -race' on go 1.4.2. This fixes them by adding an RWMutex to protect the config structure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 14:51:29 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/geodns#406
No description provided.