[PR #49] [MERGED] Added support for SRV records, plus documentation and tests #398

New issue

Closed

opened 2026-03-13 14:51:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-13 14:51:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/49
Author: @afsheenb
Created: 1/8/2014
Status: ✅ Merged
Merged: 6/8/2014
Merged by: @abh

Base: master ← Head: add_srv_records

📝 Commits (2)

cf13c1f Added support for SRV records, plus documentation and tests
8a95293 removed sshfp type def, this is not the PR we're looking for

📊 Changes

4 files changed (+48 additions, -0 deletions)

View changed files

📝 README.md (+12 -0)
📝 dns/test.example.com.json (+1 -0)
📝 serve_test.go (+7 -0)
📝 zones.go (+28 -0)

📄 Description

I've added support for SRV records, as well as basic tests and documentation. The result looks good on my dev instance:

$ dig _sip._tcp.test.example.com -t SRV @localhost

; <<>> DiG 9.9.2-P1 <<>> _sip._tcp.test.example.com -t SRV @localhost
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 50908
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0
;; WARNING: recursion requested but not available

;; QUESTION SECTION:
;_sip._tcp.test.example.com. IN SRV

;; ANSWER SECTION:
_sip._tcp.test.example.com. 600 IN SRV 10 100 5060 sipserver.example.com.

Note: I've used the variable srv_weight to distinguish between the weight that's internal to the SRV record struct vs. the "weight" that other records use. Let me know if this should be changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/49 **Author:** [@afsheenb](https://github.com/afsheenb) **Created:** 1/8/2014 **Status:** ✅ Merged **Merged:** 6/8/2014 **Merged by:** [@abh](https://github.com/abh) **Base:** `master` ← **Head:** `add_srv_records` --- ### 📝 Commits (2) - [`cf13c1f`](https://github.com/abh/geodns/commit/cf13c1feb12b1283f626bf9e168b4a0359ddb7e3) Added support for SRV records, plus documentation and tests - [`8a95293`](https://github.com/abh/geodns/commit/8a9529375a155efef12b84bf626d84dd6c96fbe2) removed sshfp type def, this is not the PR we're looking for ### 📊 Changes **4 files changed** (+48 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+12 -0) 📝 `dns/test.example.com.json` (+1 -0) 📝 `serve_test.go` (+7 -0) 📝 `zones.go` (+28 -0) </details> ### 📄 Description I've added support for SRV records, as well as basic tests and documentation. The result looks good on my dev instance: $ dig _sip._tcp.test.example.com -t SRV @localhost ; <<>> DiG 9.9.2-P1 <<>> _sip._tcp.test.example.com -t SRV @localhost ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 50908 ;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0 ;; WARNING: recursion requested but not available ;; QUESTION SECTION: ;_sip._tcp.test.example.com. IN SRV ;; ANSWER SECTION: _sip._tcp.test.example.com. 600 IN SRV 10 100 5060 sipserver.example.com. Note: I've used the variable srv_weight to distinguish between the weight that's internal to the SRV record struct vs. the "weight" that other records use. Let me know if this should be changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>