[PR #40] [MERGED] Update to newer go dns api and add benchmark #249

New issue

Closed

opened 2026-03-01 17:24:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:24:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/40
Author: @miekg
Created: 6/29/2013
Status: ✅ Merged
Merged: 11/30/2013
Merged by: @abh

Base: master ← Head: faster1

📝 Commits (2)

33c176b Add benchmark test
163dee0 Use the newer api names

📊 Changes

3 files changed (+10 additions, -4 deletions)

View changed files

📝 serve.go (+2 -2)
📝 serve_test.go (+6 -0)
📝 zone.go (+2 -2)

📄 Description

Hi,

Fiddling with the getQuestion thingy again. I added a benchmark before I started. All the changes I made never impacted the benchmark, so I leave you with these minimal changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/40 **Author:** [@miekg](https://github.com/miekg) **Created:** 6/29/2013 **Status:** ✅ Merged **Merged:** 11/30/2013 **Merged by:** [@abh](https://github.com/abh) **Base:** `master` ← **Head:** `faster1` --- ### 📝 Commits (2) - [`33c176b`](https://github.com/abh/geodns/commit/33c176b80f386d520b09e8ac8aaeb940f9b0f49d) Add benchmark test - [`163dee0`](https://github.com/abh/geodns/commit/163dee050a4495a73d8e448c4d83b03965d6db30) Use the newer api names ### 📊 Changes **3 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `serve.go` (+2 -2) 📝 `serve_test.go` (+6 -0) 📝 `zone.go` (+2 -2) </details> ### 📄 Description Hi, Fiddling with the getQuestion thingy again. I added a benchmark before I started. All the changes I made never impacted the benchmark, so I leave you with these minimal changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>