[PR #15] [MERGED] Some very minor stylistic nits. #247

New issue

Closed

opened 2026-03-01 17:24:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:24:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/15
Author: @uriel
Created: 9/20/2012
Status: ✅ Merged
Merged: 9/20/2012
Merged by: @abh

Base: master ← Head: master

📝 Commits (4)

21fcef7 Caller(s) to configReader() already start it in a goroutine.
d9158ed gofmt -s
1795a54 More idiomatic variable declarations.
cb364fa Remove redundant return.

📊 Changes

5 files changed (+10 additions, -13 deletions)

View changed files

📝 config.go (+7 -9)
📝 geoip.go (+0 -1)
📝 monitor.go (+1 -1)
📝 picker.go (+1 -1)
📝 serve.go (+1 -1)

📄 Description

Some very small fixes to make code more idiomatic.

And get rid of a 'redundant' goroutine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/15 **Author:** [@uriel](https://github.com/uriel) **Created:** 9/20/2012 **Status:** ✅ Merged **Merged:** 9/20/2012 **Merged by:** [@abh](https://github.com/abh) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`21fcef7`](https://github.com/abh/geodns/commit/21fcef7668c9d9c326217bffc79089d6089ee091) Caller(s) to configReader() already start it in a goroutine. - [`d9158ed`](https://github.com/abh/geodns/commit/d9158ed7ec5db6baebd2b30163c561f49d6e01f4) gofmt -s - [`1795a54`](https://github.com/abh/geodns/commit/1795a546487c7091c3ac7499b32c50820f467121) More idiomatic variable declarations. - [`cb364fa`](https://github.com/abh/geodns/commit/cb364fa51947aa31bf237dd32698ad42ea6e0ac9) Remove redundant return. ### 📊 Changes **5 files changed** (+10 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `config.go` (+7 -9) 📝 `geoip.go` (+0 -1) 📝 `monitor.go` (+1 -1) 📝 `picker.go` (+1 -1) 📝 `serve.go` (+1 -1) </details> ### 📄 Description Some very small fixes to make code more idiomatic. And get rid of a 'redundant' goroutine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>