[GH-ISSUE #96] Split all continents in regions #212

New issue

Open

opened 2026-03-01 17:24:35 +03:00 by kerem · 1 comment

kerem commented

2026-03-01 17:24:35 +03:00

Owner

Originally created by @daknob on GitHub (Aug 8, 2016).
Original GitHub issue: https://github.com/abh/geodns/issues/96

The United States of America is split in three parts, namely us-west, us-central, and us-east. It could be beneficial to add this support in the continent level for all continents. For example, europe-west can have Portugal, Spain, etc.

I can do this by editing the /countries/regiongroups.go which I think will enable this functionality. Is this feature wanted? Should I implement this and send a Pull Request?

Originally created by @daknob on GitHub (Aug 8, 2016). Original GitHub issue: https://github.com/abh/geodns/issues/96 The United States of America is split in three parts, namely `us-west`, `us-central`, and `us-east`. It could be beneficial to add this support in the continent level for all continents. For example, `europe-west` can have Portugal, Spain, etc. I can do this by editing the `/countries/regiongroups.go` which I think will enable this functionality. Is this feature wanted? Should I implement this and send a Pull Request?

kerem commented

2026-03-01 17:24:36 +03:00

Author

Owner

@cricsus commented on GitHub (Dec 22, 2018):

that'd also require to change the if country != "us" to if country != "us" && region != "europe", I think, right? I'm not sure whether that will work, though, as I never dealt with anything written in golang before

@cricsus commented on GitHub (Dec 22, 2018): that'd also require to change the `if country != "us"` to `if country != "us" && region != "europe"`, I think, right? I'm not sure whether that will work, though, as I never dealt with anything written in golang before