[GH-ISSUE #59] HEAD doesn't build with abh/go-metrics #191

New issue

Closed

opened 2026-03-01 17:24:27 +03:00 by kerem · 5 comments

kerem commented

2026-03-01 17:24:27 +03:00

Owner

Originally created by @leifj on GitHub (Nov 25, 2014).
Original GitHub issue: https://github.com/abh/geodns/issues/59

./metrics.go:26: cannot use metrics.NewHistogram(metrics.NewUniformSample(1800)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion
./metrics.go:29: cannot use metrics.NewHistogram(metrics.NewExpDecaySample(600, 0.015)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion
./metrics.go:32: cannot use metrics.NewGauge() (type metrics.Gauge) as type *metrics.StandardGauge in assignment: need type assertion
./zone.go:85: cannot use metrics.NewMeter() (type metrics.Meter) as type *metrics.StandardMeter in assignment: need type assertion

Originally created by @leifj on GitHub (Nov 25, 2014). Original GitHub issue: https://github.com/abh/geodns/issues/59 ./metrics.go:26: cannot use metrics.NewHistogram(metrics.NewUniformSample(1800)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion ./metrics.go:29: cannot use metrics.NewHistogram(metrics.NewExpDecaySample(600, 0.015)) (type metrics.Histogram) as type *metrics.StandardHistogram in assignment: need type assertion ./metrics.go:32: cannot use metrics.NewGauge() (type metrics.Gauge) as type *metrics.StandardGauge in assignment: need type assertion ./zone.go:85: cannot use metrics.NewMeter() (type metrics.Meter) as type *metrics.StandardMeter in assignment: need type assertion

kerem closed this issue

2026-03-01 17:24:27 +03:00

kerem commented

2026-03-01 17:24:27 +03:00

Author

Owner

@leifj commented on GitHub (Nov 25, 2014):

This is go1.2.1 btw

@leifj commented on GitHub (Nov 25, 2014): This is go1.2.1 btw

kerem commented

2026-03-01 17:24:27 +03:00

Author

Owner

@leifj commented on GitHub (Nov 25, 2014):

actually I think I'm wrong. I was looking at a local branch

@leifj commented on GitHub (Nov 25, 2014): actually I think I'm wrong. I was looking at a local branch

kerem commented

2026-03-01 17:24:28 +03:00

Author

Owner

@abh commented on GitHub (Nov 25, 2014):

I think what you are saying is that I should make a godep file. :-)

@abh commented on GitHub (Nov 25, 2014): I think what you are saying is that I should make a godep file. :-)

kerem commented

2026-03-01 17:24:28 +03:00

Author

Owner

@leifj commented on GitHub (Nov 25, 2014):

On 2014-11-25 16:41, Ask Bjørn Hansen wrote:

I think what you are saying is that I should make a godep file. :-)

—
Reply to this email directly or view it on GitHub
https://github.com/abh/geodns/issues/59#issuecomment-64418895.

yeah maybe :-)

@leifj commented on GitHub (Nov 25, 2014): On 2014-11-25 16:41, Ask Bjørn Hansen wrote: > I think what you are saying is that I should make a godep file. :-) > > — > Reply to this email directly or view it on GitHub > https://github.com/abh/geodns/issues/59#issuecomment-64418895. > > yeah maybe :-)

kerem commented

2026-03-01 17:24:28 +03:00

Author

Owner

@abh commented on GitHub (Nov 26, 2014):

Looks like I started on that in

commit 24ce842203
Author: Ask Bjørn Hansen
Date: Sun Oct 19 15:03:32 2014 -0700

Use godep to track dependencies

:-)

@abh commented on GitHub (Nov 26, 2014): Looks like I started on that in commit 24ce842203c348e4b30eff00819a5f6384bb5235 Author: Ask Bjørn Hansen Date: Sun Oct 19 15:03:32 2014 -0700 ``` Use godep to track dependencies ``` :-)