[PR #80] [CLOSED] Skip unchanged zonefiles #123

New issue

Closed

opened 2026-02-28 14:16:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:16:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/80
Author: @abligh
Created: 9/2/2015
Status: ❌ Closed

Base: master ← Head: skip-unchanged-zonefiles

📝 Commits (10+)

75f2193 Fix race referencing config
9ea0491 Move last modified time out of zone
c99b922 Fix crash on removal of zonefile with invalid JSON (Issue #69)
63f15b8 Fix issue #74 - crash on reenabling previously invalid zone
ed3f369 Ignore files beginning with dots and directories
f5dcd56 Add 'closest' flag
ead82fa Add healthtest functionality to automatically exclude down hosts
aeb6881 Only perform one health test per IP / parameter tuple
52720f9 Add ability to log to file
7df349a Add a health RR

📊 Changes

14 files changed (+837 additions, -50 deletions)

View changed files

📝 config.go (+23 -1)
📝 geodns.go (+8 -3)
📝 geoip.go (+29 -3)
➕ heathtest.go (+426 -0)
📝 log.go (+74 -1)
📝 picker.go (+75 -8)
📝 serve.go (+51 -3)
📝 stathat.go (+7 -7)
📝 targeting.go (+5 -6)
📝 targeting_test.go (+5 -5)
📝 zone.go (+47 -6)
📝 zone_test.go (+4 -1)
📝 zones.go (+82 -6)
📝 zones_test.go (+1 -0)

📄 Description

Do not reload zonefiles which are entirely unchanged as determined by SHA256 hash. In an environment where (e.g.) zones are PUT using a REST API the same zone may be delivered in a situation where it is entirely unchanged. In this circumstance is it useful to avoid reloading it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/80 **Author:** [@abligh](https://github.com/abligh) **Created:** 9/2/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `skip-unchanged-zonefiles` --- ### 📝 Commits (10+) - [`75f2193`](https://github.com/abh/geodns/commit/75f21937fb32dd445ddc8d856c5832fa434dc0ec) Fix race referencing config - [`9ea0491`](https://github.com/abh/geodns/commit/9ea0491eb4fc9e73554508f41ecb09bd20928eee) Move last modified time out of zone - [`c99b922`](https://github.com/abh/geodns/commit/c99b92208cd405218b9522a91d1ea45f5fe27ee8) Fix crash on removal of zonefile with invalid JSON (Issue #69) - [`63f15b8`](https://github.com/abh/geodns/commit/63f15b8bd560e7e976b742c2c18eb391b330a267) Fix issue #74 - crash on reenabling previously invalid zone - [`ed3f369`](https://github.com/abh/geodns/commit/ed3f36975d0108087e72600ec940850eb58beae6) Ignore files beginning with dots and directories - [`f5dcd56`](https://github.com/abh/geodns/commit/f5dcd56e3f979abb4df7703887d308e40af21679) Add 'closest' flag - [`ead82fa`](https://github.com/abh/geodns/commit/ead82fa4ec4c23cf6a1755c1efe6dac5979c68ca) Add healthtest functionality to automatically exclude down hosts - [`aeb6881`](https://github.com/abh/geodns/commit/aeb6881ad992181fd29db60f8ee1144d875d7cbf) Only perform one health test per IP / parameter tuple - [`52720f9`](https://github.com/abh/geodns/commit/52720f947810d20eb62b30a422b27583a4027c6a) Add ability to log to file - [`7df349a`](https://github.com/abh/geodns/commit/7df349adf010996860199ea2e4a7cc29515fcdd3) Add a health RR ### 📊 Changes **14 files changed** (+837 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `config.go` (+23 -1) 📝 `geodns.go` (+8 -3) 📝 `geoip.go` (+29 -3) ➕ `heathtest.go` (+426 -0) 📝 `log.go` (+74 -1) 📝 `picker.go` (+75 -8) 📝 `serve.go` (+51 -3) 📝 `stathat.go` (+7 -7) 📝 `targeting.go` (+5 -6) 📝 `targeting_test.go` (+5 -5) 📝 `zone.go` (+47 -6) 📝 `zone_test.go` (+4 -1) 📝 `zones.go` (+82 -6) 📝 `zones_test.go` (+1 -0) </details> ### 📄 Description Do not reload zonefiles which are entirely unchanged as determined by SHA256 hash. In an environment where (e.g.) zones are PUT using a REST API the same zone may be delivered in a situation where it is entirely unchanged. In this circumstance is it useful to avoid reloading it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>