[PR #77] [CLOSED] Move last read out of zone #120

Closed
opened 2026-02-28 14:16:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/abh/geodns/pull/77
Author: @abligh
Created: 8/31/2015
Status: Closed

Base: masterHead: move-last-read-out-of-zone


📝 Commits (2)

  • 75f2193 Fix race referencing config
  • 9ea0491 Move last modified time out of zone

📊 Changes

8 files changed (+47 additions, -17 deletions)

View changed files

📝 config.go (+23 -1)
📝 geodns.go (+2 -2)
📝 geoip.go (+3 -2)
📝 stathat.go (+7 -7)
📝 zone.go (+0 -2)
📝 zone_test.go (+4 -1)
📝 zones.go (+6 -2)
📝 zones_test.go (+2 -0)

📄 Description

Only load zones when they parse correctly, but record the modify time whenever we try to parse them. This fixes the issue of constantly trying to reparse broken zones.

Discussed under pull request #69


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/abh/geodns/pull/77 **Author:** [@abligh](https://github.com/abligh) **Created:** 8/31/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `move-last-read-out-of-zone` --- ### 📝 Commits (2) - [`75f2193`](https://github.com/abh/geodns/commit/75f21937fb32dd445ddc8d856c5832fa434dc0ec) Fix race referencing config - [`9ea0491`](https://github.com/abh/geodns/commit/9ea0491eb4fc9e73554508f41ecb09bd20928eee) Move last modified time out of zone ### 📊 Changes **8 files changed** (+47 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `config.go` (+23 -1) 📝 `geodns.go` (+2 -2) 📝 `geoip.go` (+3 -2) 📝 `stathat.go` (+7 -7) 📝 `zone.go` (+0 -2) 📝 `zone_test.go` (+4 -1) 📝 `zones.go` (+6 -2) 📝 `zones_test.go` (+2 -0) </details> ### 📄 Description Only load zones when they parse correctly, but record the modify time whenever we try to parse them. This fixes the issue of constantly trying to reparse broken zones. Discussed under pull request #69 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:16:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/geodns#120
No description provided.