mirror of
https://github.com/mthenw/frontail.git
synced 2026-04-26 10:15:52 +03:00
[GH-ISSUE #20] Closing one and starting another on the same port #15
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/frontail#15
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ardavis on GitHub (Sep 19, 2013).
Original GitHub issue: https://github.com/mthenw/frontail/issues/20
Originally assigned to: @mthenw on GitHub.
I have a script that streams with frontail on a port, when it's complete, I allow someone else to stream a file on that same port (now that it's available). If the first person doesn't close their browser, they can now see a stream of the 2nd person's file. Any idea how to circumvent this?
@mthenw commented on GitHub (Sep 21, 2013):
Currently I'm on the middle of refactoring. I will fix this in a few days.
@ardavis commented on GitHub (Oct 21, 2013):
How is this going, anything I can do to help? Hope you've been doing well, and thanks again for this great gem!
@mthenw commented on GitHub (Oct 21, 2013):
Still refactoring. Sorry for telling that I will fix this in few days and not doing it. I will try to fix this till the end of week, but I can't promise.
@ardavis commented on GitHub (Oct 21, 2013):
No worries :)
On Mon, Oct 21, 2013 at 1:21 PM, Maciej Winnicki
notifications@github.comwrote:
@mthenw commented on GitHub (Oct 29, 2013):
I thought about this feature and I reached a conclusion that this should not be forbidden or maybe forbidden only if user and password provided. Could you provide more details why is it important?
@ardavis commented on GitHub (Oct 29, 2013):
At work we are using frontail to run "builds" (lots of scripts), and I stream it to the user. There are 3 users that use this tool. If one user kicks off a build, and watches the stream, and it finishes. Then another user later kicks off a build, it reuses the same streaming port. So the first user will now see the stream of the 2nd user. I'm not really sure how to go about it. Thoughts? Let me know if you need more info.
@mthenw commented on GitHub (Oct 29, 2013):
Are those streams come from same file?
@ardavis commented on GitHub (Oct 29, 2013):
No sir. But they are being streamed on the same port. I kick off the
streaming service on a port, then later kill it.
On Tue, Oct 29, 2013 at 3:05 PM, Maciej Winnicki
notifications@github.comwrote:
@mthenw commented on GitHub (Oct 29, 2013):
I think that the best solution will be to relate streamed file with browser session. In your example, if user1 will open frontail for /var/log1 then frontail will be killed and other file will be streamed, user1 will not see new log. But if later sb will run frontail for /var/log1 again user1 will get new logs without refreshing page. What do you think?
@ardavis commented on GitHub (Oct 29, 2013):
I actually think that's an amazing idea. Do you know how to implement
something like that?
On Tue, Oct 29, 2013 at 6:22 PM, Maciej Winnicki
notifications@github.comwrote:
@mthenw commented on GitHub (Nov 6, 2013):
I've made it using socket.io namespaces. Could you test it? It's on
file-as-nsbranch.@ardavis commented on GitHub (Nov 6, 2013):
Yes sir, I'll give it a shot soon. Thanks!
@ardavis commented on GitHub (Nov 6, 2013):
Victory! I have successfully streamed two different files on the same port and they did not affect each other. Thank you very much.
@mthenw commented on GitHub (Nov 6, 2013):
OK, so I merging this and releasing new version.
@ardavis commented on GitHub (Nov 6, 2013):
Excellent. Greatly appreciated. Once it's released we'll start using it right away.
@mthenw commented on GitHub (Nov 6, 2013):
Done (fixed with
d8b31ff5f6).Version 0.6.0 available.