mirror of
https://github.com/mthenw/frontail.git
synced 2026-04-26 02:05:57 +03:00
[GH-ISSUE #160] Not shutting down via signals if usage reporting is disabled #111
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/frontail#111
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @apeteri on GitHub (Feb 11, 2019).
Original GitHub issue: https://github.com/mthenw/frontail/issues/160
Hi Maciej,
I am using release 4.5.3 with a systemd service script, and I have noticed that the service waits for the whole ~90 second grace period when stopping, before it gets killed forcefully. Systemd attempts to stop a service by sending
SIGTERMto its process group by default.It seems that the callback for usage stats reporting in
stats.jsis not invoked if notrackerinstance exists:github.com/mthenw/frontail@205cdbf696/lib/stats.js (L57-L63)Due to this, signals have no effect at the end of
index.js:github.com/mthenw/frontail@205cdbf696/index.js (L159-L165)Regards,
András
@apeteri commented on GitHub (Feb 15, 2019):
Possible duplicate of #158.
@mthenw commented on GitHub (Feb 20, 2019):
Thanks for reporting. I will take a look.
@mthenw commented on GitHub (Feb 21, 2019):
I released new version v.4.5.4. Please confirm that it works now.
@apeteri commented on GitHub (Mar 1, 2019):
Looks good, now the process stops immediately. Thanks! 😃