[PR #298] [MERGED] Implement Smart Cropping feature, fixes #129 #995

Closed
opened 2026-03-15 15:46:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/298
Author: @sadok-f
Created: 1/1/2021
Status: Merged
Merged: 1/2/2021
Merged by: @sadok-f

Base: mainHead: issue#129


📝 Commits (10+)

  • 54b8ab0 Implement Smart Croppiing feature, fixes #129
  • 81ca53a Fixing linting
  • 499a8b7 Fixing linting errors
  • c477c0b Fixing linting and unit tests errors
  • 576b401 Fixing python linting errors
  • a971e37 Add Unit tests for Smart Cropping feature
  • a6cf35b Add pillow installation in Dockerfile
  • 95bdc40 Update docs, smart crop logic
  • dcd95c2 Update docs for smart crop
  • fd0d559 Update docs for smart crop

📊 Changes

12 files changed (+506 additions, -3 deletions)

View changed files

📝 Dockerfile (+1 -0)
📝 README.md (+31 -3)
📝 config/parameters.yml (+2 -0)
python/smartcrop.py (+381 -0)
📝 src/Core/Handler/ImageHandler.php (+22 -0)
📝 src/Core/Processor/Processor.php (+3 -0)
src/Core/Processor/SmartCropProcessor.php (+37 -0)
📝 tests/Core/BaseTest.php (+3 -0)
📝 tests/Core/Entity/Image/OutputImageTest.php (+1 -0)
tests/Core/Processor/SmartCropProcessorTest.php (+25 -0)
tests/testImages/smart_crop.jpg (+0 -0)
tests/testImages/smart_crop_restult.jpg (+0 -0)

📄 Description

A very wanted feature: Smart Cropping.
I added a python script to determine to best coordinates for cropping.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/298 **Author:** [@sadok-f](https://github.com/sadok-f) **Created:** 1/1/2021 **Status:** ✅ Merged **Merged:** 1/2/2021 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `main` ← **Head:** `issue#129` --- ### 📝 Commits (10+) - [`54b8ab0`](https://github.com/flyimg/flyimg/commit/54b8ab0da6fd475e4a9ee7506200e7d673145b2c) Implement Smart Croppiing feature, fixes #129 - [`81ca53a`](https://github.com/flyimg/flyimg/commit/81ca53a0aeb099a381fe2df85c88e0cb423fdcf6) Fixing linting - [`499a8b7`](https://github.com/flyimg/flyimg/commit/499a8b7557fcbb56ce6629ca2421a058bd737f49) Fixing linting errors - [`c477c0b`](https://github.com/flyimg/flyimg/commit/c477c0bfdc9f1d639618414458d93bdcb695fc60) Fixing linting and unit tests errors - [`576b401`](https://github.com/flyimg/flyimg/commit/576b40199a8f3bb1ac7830b04034967ff7b099a0) Fixing python linting errors - [`a971e37`](https://github.com/flyimg/flyimg/commit/a971e3799e0de68f4862d621313b8c81ed9311e4) Add Unit tests for Smart Cropping feature - [`a6cf35b`](https://github.com/flyimg/flyimg/commit/a6cf35be7a5b769acd35817a39b8933fe8abb6f5) Add pillow installation in Dockerfile - [`95bdc40`](https://github.com/flyimg/flyimg/commit/95bdc409f64a862f7816d3f20e60815ee02d1c4f) Update docs, smart crop logic - [`dcd95c2`](https://github.com/flyimg/flyimg/commit/dcd95c21be1f89d2a18a4c71df613dac54752ece) Update docs for smart crop - [`fd0d559`](https://github.com/flyimg/flyimg/commit/fd0d559ff653eddb0919541d0353392577de4cb5) Update docs for smart crop ### 📊 Changes **12 files changed** (+506 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+1 -0) 📝 `README.md` (+31 -3) 📝 `config/parameters.yml` (+2 -0) ➕ `python/smartcrop.py` (+381 -0) 📝 `src/Core/Handler/ImageHandler.php` (+22 -0) 📝 `src/Core/Processor/Processor.php` (+3 -0) ➕ `src/Core/Processor/SmartCropProcessor.php` (+37 -0) 📝 `tests/Core/BaseTest.php` (+3 -0) 📝 `tests/Core/Entity/Image/OutputImageTest.php` (+1 -0) ➕ `tests/Core/Processor/SmartCropProcessorTest.php` (+25 -0) ➕ `tests/testImages/smart_crop.jpg` (+0 -0) ➕ `tests/testImages/smart_crop_restult.jpg` (+0 -0) </details> ### 📄 Description A very wanted feature: Smart Cropping. I added a python script to determine to best coordinates for cropping. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 15:46:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#995
No description provided.