[PR #195] [CLOSED] [WiP] Refactoring and migration to Symfony 4.1 #935

New issue

Closed

opened 2026-03-15 15:43:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 15:43:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/195
Author: @gplanchat
Created: 9/20/2018
Status: ❌ Closed

Base: master ← Head: refactoring-194

📝 Commits (10+)

4399e8c Created new image file manipulation models
92f6131 Created new image file manipulation commands
c862283 Created new face detection tool
3967cf0 Fixed method calls related to old InputImage and OutputImage
abe8bfe Added refactored exceptions
e484a4b Started migration to Symfony 4.1, PoC
7e286cf Migrated image manipulation to imagine/imagine
4325a96 Fixed last HTTP issues
a45f00d Added bundles list and namespace changes in the app config
9167033 Added new face detection commands, refactored a bit the face detection class

📊 Changes

125 files changed (+5740 additions, -1219 deletions)

View changed files

➕ .docker/nginx/conf.d/flyimage.conf (+24 -0)
➕ .env (+10 -0)
➕ .env.dist (+10 -0)
📝 .gitignore (+8 -0)
📝 README.md (+1 -1)
📝 app.php (+6 -1)
➕ bin/console (+39 -0)
📝 composer.json (+105 -51)
📝 composer.lock (+1605 -692)
➕ config/bundles.php (+7 -0)
➕ config/packages/dev/routing.yaml (+3 -0)
➕ config/packages/framework.yaml (+30 -0)
➕ config/packages/routing.yaml (+3 -0)
➕ config/packages/test/framework.yaml (+4 -0)
➕ config/packages/test/routing.yaml (+3 -0)
➕ config/packages/translation.yaml (+6 -0)
➕ config/packages/twig.yaml (+4 -0)
➕ config/packages/validator.yaml (+3 -0)
➕ config/routes.yaml (+27 -0)
➖ config/routes.yml (+0 -14)

...and 80 more files

📄 Description

Refactoring various items:

#194 Refactor Images entities classes and FaceDetectProcessor
#184 Silex end of life => migrate to Symfony 4?
Migrate the image operations to imagine/imagine library
Refactor the image operations to a command pattern
Refactor the security management
Refactor the options handling
Move the image manipulation features to Flyimg\Image\ namespace
Move the HTTP security and parameters handling features to Flyimg\Http\ namespace
Move the application-specific features to Flyimg\App\ namespace

The document root directory has been changed to follow Symfony 4.1 recommendations, please use this config file in the Docker app:

# /etc/nginx/conf.d/flyimage.conf
server {
    listen  80;
    root  /var/www/html/public;

    location / {
        # try to serve file directly, fallback to index.php
        try_files $uri /index.php$is_args$args;
    }

    location ~ ^/index.php(/|$) {
        fastcgi_pass 127.0.0.1:9000;
        fastcgi_split_path_info ^(.+\.php)(/.*)$;
        include fastcgi_params;
        fastcgi_param  SCRIPT_FILENAME  $realpath_root$fastcgi_script_name;
        fastcgi_param DOCUMENT_ROOT $realpath_root;
        proxy_read_timeout 300;
    }

    error_page 504 /error_504.html;
    location = /error_504.html{
        root /var/www/html/public;
        internal;
    }
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/195 **Author:** [@gplanchat](https://github.com/gplanchat) **Created:** 9/20/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactoring-194` --- ### 📝 Commits (10+) - [`4399e8c`](https://github.com/flyimg/flyimg/commit/4399e8c2785f72a15b0b7ac7925ac8c82122f5f3) Created new image file manipulation models - [`92f6131`](https://github.com/flyimg/flyimg/commit/92f6131b897e7b085ccc1b40ad58ade133af7cae) Created new image file manipulation commands - [`c862283`](https://github.com/flyimg/flyimg/commit/c862283a9cab41c0e65dd4e88ddc2ca7a2868d5b) Created new face detection tool - [`3967cf0`](https://github.com/flyimg/flyimg/commit/3967cf0dcd742568832a8b8be6b825addb03d93c) Fixed method calls related to old InputImage and OutputImage - [`abe8bfe`](https://github.com/flyimg/flyimg/commit/abe8bfe1bc8ed78da0fa22a14a52986afcbd7b97) Added refactored exceptions - [`e484a4b`](https://github.com/flyimg/flyimg/commit/e484a4b8addbedee99c74004ea902f927241dd02) Started migration to Symfony 4.1, PoC - [`7e286cf`](https://github.com/flyimg/flyimg/commit/7e286cff1980319373c7a3f16f72a0b09b4fee97) Migrated image manipulation to imagine/imagine - [`4325a96`](https://github.com/flyimg/flyimg/commit/4325a968a18b487dc27d2f5e845ac0432e565325) Fixed last HTTP issues - [`a45f00d`](https://github.com/flyimg/flyimg/commit/a45f00d534ff12bb0cca76c6ae5545856d43abf8) Added bundles list and namespace changes in the app config - [`9167033`](https://github.com/flyimg/flyimg/commit/9167033b9486ca535dd576defe81c72f0dde06ad) Added new face detection commands, refactored a bit the face detection class ### 📊 Changes **125 files changed** (+5740 additions, -1219 deletions) <details> <summary>View changed files</summary> ➕ `.docker/nginx/conf.d/flyimage.conf` (+24 -0) ➕ `.env` (+10 -0) ➕ `.env.dist` (+10 -0) 📝 `.gitignore` (+8 -0) 📝 `README.md` (+1 -1) 📝 `app.php` (+6 -1) ➕ `bin/console` (+39 -0) 📝 `composer.json` (+105 -51) 📝 `composer.lock` (+1605 -692) ➕ `config/bundles.php` (+7 -0) ➕ `config/packages/dev/routing.yaml` (+3 -0) ➕ `config/packages/framework.yaml` (+30 -0) ➕ `config/packages/routing.yaml` (+3 -0) ➕ `config/packages/test/framework.yaml` (+4 -0) ➕ `config/packages/test/routing.yaml` (+3 -0) ➕ `config/packages/translation.yaml` (+6 -0) ➕ `config/packages/twig.yaml` (+4 -0) ➕ `config/packages/validator.yaml` (+3 -0) ➕ `config/routes.yaml` (+27 -0) ➖ `config/routes.yml` (+0 -14) _...and 80 more files_ </details> ### 📄 Description Refactoring various items: * [x] #194 Refactor Images entities classes and FaceDetectProcessor * [ ] #184 Silex end of life => migrate to Symfony 4? * [x] Migrate the image operations to `imagine/imagine` library * [x] Refactor the image operations to a command pattern * [x] Refactor the security management * [x] Refactor the options handling * [x] Move the image manipulation features to `Flyimg\Image\` namespace * [x] Move the HTTP security and parameters handling features to `Flyimg\Http\` namespace * [x] Move the application-specific features to `Flyimg\App\` namespace The document root directory has been changed to follow Symfony 4.1 recommendations, please use this config file in the Docker app: ``` # /etc/nginx/conf.d/flyimage.conf server { listen 80; root /var/www/html/public; location / { # try to serve file directly, fallback to index.php try_files $uri /index.php$is_args$args; } location ~ ^/index.php(/|$) { fastcgi_pass 127.0.0.1:9000; fastcgi_split_path_info ^(.+\.php)(/.*)$; include fastcgi_params; fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name; fastcgi_param DOCUMENT_ROOT $realpath_root; proxy_read_timeout 300; } error_page 504 /error_504.html; location = /error_504.html{ root /var/www/html/public; internal; } } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>