[PR #136] [MERGED] Replace getters and setters names with meaning names, closes #135 #903

New issue

Closed

opened 2026-03-15 15:42:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 15:42:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/136
Author: @sadok-f
Created: 10/21/2017
Status: ✅ Merged
Merged: 10/25/2017
Merged by: @sadok-f

Base: master ← Head: issue-#135

📝 Commits (4)

3fff13e Replace getters and setters names with meaning neames
f81bc78 closes #135, fix Codelimate warnings
6310c91 cleanup, closes #135
5186a1a cleanup, closes #135

📊 Changes

23 files changed (+371 additions, -303 deletions)

View changed files

📝 app.php (+3 -3)
📝 src/Core/Controller/CoreController.php (+15 -10)
📝 src/Core/Controller/DefaultController.php (+2 -2)
📝 src/Core/Entity/AppParameters.php (+2 -2)
📝 src/Core/Entity/Image/InputImage.php (+10 -10)
📝 src/Core/Entity/Image/OutputImage.php (+19 -31)
📝 src/Core/Entity/ImageMetaInfo.php (+40 -30)
📝 src/Core/Entity/OptionsBag.php (+4 -4)
📝 src/Core/Handler/ImageHandler.php (+14 -14)
📝 src/Core/Handler/SecurityHandler.php (+7 -7)
📝 src/Core/Processor/ExtractProcessor.php (+3 -3)
📝 src/Core/Processor/FaceDetectProcessor.php (+6 -6)
📝 src/Core/Processor/ImageProcessor.php (+75 -51)
📝 src/Core/Processor/Processor.php (+2 -2)
📝 src/Core/Resolver/ControllerResolver.php (+1 -1)
📝 src/Core/StorageProvider/S3StorageProvider.php (+1 -1)
📝 tests/Core/BaseTest.php (+6 -2)
📝 tests/Core/Entity/Image/InputImageTest.php (+1 -1)
📝 tests/Core/Entity/Image/OutputImageTest.php (+9 -9)
📝 tests/Core/Entity/ImageMetaInfoTest.php (+56 -28)

...and 3 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/136 **Author:** [@sadok-f](https://github.com/sadok-f) **Created:** 10/21/2017 **Status:** ✅ Merged **Merged:** 10/25/2017 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `master` ← **Head:** `issue-#135` --- ### 📝 Commits (4) - [`3fff13e`](https://github.com/flyimg/flyimg/commit/3fff13e89bf9f60d26c06498d0be038c53e07277) Replace getters and setters names with meaning neames - [`f81bc78`](https://github.com/flyimg/flyimg/commit/f81bc7838c55b548e559bc3b6d67ba574d11856d) closes #135, fix Codelimate warnings - [`6310c91`](https://github.com/flyimg/flyimg/commit/6310c9167bb869758bec4e7776e11c74d8a41bcc) cleanup, closes #135 - [`5186a1a`](https://github.com/flyimg/flyimg/commit/5186a1a9826392ee15b5f16c8e1992adb51afe3c) cleanup, closes #135 ### 📊 Changes **23 files changed** (+371 additions, -303 deletions) <details> <summary>View changed files</summary> 📝 `app.php` (+3 -3) 📝 `src/Core/Controller/CoreController.php` (+15 -10) 📝 `src/Core/Controller/DefaultController.php` (+2 -2) 📝 `src/Core/Entity/AppParameters.php` (+2 -2) 📝 `src/Core/Entity/Image/InputImage.php` (+10 -10) 📝 `src/Core/Entity/Image/OutputImage.php` (+19 -31) 📝 `src/Core/Entity/ImageMetaInfo.php` (+40 -30) 📝 `src/Core/Entity/OptionsBag.php` (+4 -4) 📝 `src/Core/Handler/ImageHandler.php` (+14 -14) 📝 `src/Core/Handler/SecurityHandler.php` (+7 -7) 📝 `src/Core/Processor/ExtractProcessor.php` (+3 -3) 📝 `src/Core/Processor/FaceDetectProcessor.php` (+6 -6) 📝 `src/Core/Processor/ImageProcessor.php` (+75 -51) 📝 `src/Core/Processor/Processor.php` (+2 -2) 📝 `src/Core/Resolver/ControllerResolver.php` (+1 -1) 📝 `src/Core/StorageProvider/S3StorageProvider.php` (+1 -1) 📝 `tests/Core/BaseTest.php` (+6 -2) 📝 `tests/Core/Entity/Image/InputImageTest.php` (+1 -1) 📝 `tests/Core/Entity/Image/OutputImageTest.php` (+9 -9) 📝 `tests/Core/Entity/ImageMetaInfoTest.php` (+56 -28) _...and 3 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>