[PR #124] [MERGED] [WIP]: Added more cases for the tests. Fixes #115. Added Image Info to the source image … #900

Closed
opened 2026-03-15 15:41:44 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/124
Author: @baamenabar
Created: 9/4/2017
Status: Merged
Merged: 9/8/2017
Merged by: @baamenabar

Base: masterHead: resizing-tests


📝 Commits (5)

  • 3e2f593 Added more cases for the tests. Added Image Info to the source image (needed for calculations).
  • 2330d8c Removed forgotten unused methods
  • 3d5a4b0 Added ImageMetaInfo Class and updated tests.
  • 4ef04cc Added Unit tests for ImageMetaInfo, fixed test broken by reoving the thread URL option.
  • c5cdbc3 Removing unused methods for now. Minor code style fixes.

📊 Changes

11 files changed (+407 additions, -52 deletions)

View changed files

📝 config/parameters.yml (+6 -5)
src/Core/Entity/Image/ImageMetaInfo.php (+206 -0)
📝 src/Core/Entity/Image/InputImage.php (+10 -5)
📝 src/Core/Processor/ImageProcessor.php (+17 -6)
📝 src/Core/Processor/Processor.php (+1 -1)
tests/Core/Entity/Image/ImageMetaInfoTest.php (+96 -0)
📝 tests/Core/Entity/Image/OutputImageTest.php (+4 -1)
📝 tests/Core/Processor/ImageProcessorTest.php (+67 -34)
tests/testImages/landscape-color-squares-300x200.png (+0 -0)
tests/testImages/portrait-color-squares-200x300.png (+0 -0)
tests/testImages/square-opaque-200.png (+0 -0)

📄 Description

…(needed for calculations).

There are double the tests, but the later half is deactivater


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/124 **Author:** [@baamenabar](https://github.com/baamenabar) **Created:** 9/4/2017 **Status:** ✅ Merged **Merged:** 9/8/2017 **Merged by:** [@baamenabar](https://github.com/baamenabar) **Base:** `master` ← **Head:** `resizing-tests` --- ### 📝 Commits (5) - [`3e2f593`](https://github.com/flyimg/flyimg/commit/3e2f593786552f58b66b47379d3adcf301ef084f) Added more cases for the tests. Added Image Info to the source image (needed for calculations). - [`2330d8c`](https://github.com/flyimg/flyimg/commit/2330d8c0d0850a5dc945b6bda33138d3c9b0a29c) Removed forgotten unused methods - [`3d5a4b0`](https://github.com/flyimg/flyimg/commit/3d5a4b06fd01e447a922be96d753a3094c8838d4) Added ImageMetaInfo Class and updated tests. - [`4ef04cc`](https://github.com/flyimg/flyimg/commit/4ef04cc276ab6f79325d62fc242dc82134f1ca9b) Added Unit tests for ImageMetaInfo, fixed test broken by reoving the thread URL option. - [`c5cdbc3`](https://github.com/flyimg/flyimg/commit/c5cdbc301e0a71a156687d417c43c354d83a08c8) Removing unused methods for now. Minor code style fixes. ### 📊 Changes **11 files changed** (+407 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `config/parameters.yml` (+6 -5) ➕ `src/Core/Entity/Image/ImageMetaInfo.php` (+206 -0) 📝 `src/Core/Entity/Image/InputImage.php` (+10 -5) 📝 `src/Core/Processor/ImageProcessor.php` (+17 -6) 📝 `src/Core/Processor/Processor.php` (+1 -1) ➕ `tests/Core/Entity/Image/ImageMetaInfoTest.php` (+96 -0) 📝 `tests/Core/Entity/Image/OutputImageTest.php` (+4 -1) 📝 `tests/Core/Processor/ImageProcessorTest.php` (+67 -34) ➕ `tests/testImages/landscape-color-squares-300x200.png` (+0 -0) ➕ `tests/testImages/portrait-color-squares-200x300.png` (+0 -0) ➕ `tests/testImages/square-opaque-200.png` (+0 -0) </details> ### 📄 Description …(needed for calculations). There are double the tests, but the later half is deactivater --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 15:41:44 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#900
No description provided.