[PR #113] [MERGED] Refactor: Clarified and separated logic for output file extensions, closes #114 #891

New issue

Closed

opened 2026-03-15 15:41:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 15:41:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/113
Author: @baamenabar
Created: 8/25/2017
Status: ✅ Merged
Merged: 8/25/2017
Merged by: @baamenabar

Base: master ← Head: format-options-refactor

📝 Commits (3)

3bd7444 Refactor: Clarified and separated logic for output file extensions
087e7a9 Fix for variable name too long. Can't we make them longer? 20 is not enough
9881323 removed unneeded comment

📊 Changes

5 files changed (+113 additions, -47 deletions)

View changed files

📝 README.md (+2 -2)
📝 docs/url-options.md (+4 -2)
📝 src/Core/Entity/OutputImage.php (+97 -33)
📝 src/Core/Handler/ImageHandler.php (+2 -2)
📝 src/Core/Processor/ImageProcessor.php (+8 -8)

📄 Description

Do we have defined rules regarding whitespace? do we follow some guideline?

Also, can I return early in a method?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/113 **Author:** [@baamenabar](https://github.com/baamenabar) **Created:** 8/25/2017 **Status:** ✅ Merged **Merged:** 8/25/2017 **Merged by:** [@baamenabar](https://github.com/baamenabar) **Base:** `master` ← **Head:** `format-options-refactor` --- ### 📝 Commits (3) - [`3bd7444`](https://github.com/flyimg/flyimg/commit/3bd74448a7b698a6ee614522e4637d7233d6e68b) Refactor: Clarified and separated logic for output file extensions - [`087e7a9`](https://github.com/flyimg/flyimg/commit/087e7a9366ffaa36011da8f6e52c19e9d1bba57d) Fix for variable name too long. Can't we make them longer? 20 is not enough - [`9881323`](https://github.com/flyimg/flyimg/commit/9881323e49bec132a62a2eed91b92033c02fa644) removed unneeded comment ### 📊 Changes **5 files changed** (+113 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -2) 📝 `docs/url-options.md` (+4 -2) 📝 `src/Core/Entity/OutputImage.php` (+97 -33) 📝 `src/Core/Handler/ImageHandler.php` (+2 -2) 📝 `src/Core/Processor/ImageProcessor.php` (+8 -8) </details> ### 📄 Description Do we have defined rules regarding whitespace? do we follow some guideline? Also, can I return early in a method? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>