[PR #38] [CLOSED] Partial PNG support. #850

Closed
opened 2026-03-15 15:39:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/38
Author: @baamenabar
Created: 1/31/2017
Status: Closed

Base: masterHead: png-support


📝 Commits (2)

  • d624265 Merge remote-tracking branch 'origin/master' into png-support
  • 62fabe8 Added PNG support by default. Does not work in combination with enabled webp conversion

📊 Changes

3 files changed (+134 additions, -23 deletions)

View changed files

📝 src/Core/Controller/CoreController.php (+2 -1)
📝 src/Core/Entity/Image.php (+123 -7)
📝 src/Core/Service/ImageProcessor.php (+9 -15)

📄 Description

Added an identify method but need review.

Does not work with webP enabled

this url http://192.168.96.100:8080/upload/w_601,h_601,rf_1/https://raw.githubusercontent.com/flyimg/graphic-assets/master/logo/raster/flyimg-logo-rgb.png
will throw

The last line of output: /usr/bin/convert /var/www/html/var/tmp/588fdbd8ec3d38.74595512 -thumbnail 601x601\> -gravity Center -extent 601x601+repage -colorspace sRGB -limit thread '1' -strip -filter 'Lanczos' -sampling-factor '1x1' -quality '90' '/var/www/html/var/tmp/2dd91029ea511b906ac262d82768bd5b-588fdbd8f33cd4.11918861.webp'


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/38 **Author:** [@baamenabar](https://github.com/baamenabar) **Created:** 1/31/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `png-support` --- ### 📝 Commits (2) - [`d624265`](https://github.com/flyimg/flyimg/commit/d624265d7cd2561f808509c1ce36e2d0faa428c3) Merge remote-tracking branch 'origin/master' into png-support - [`62fabe8`](https://github.com/flyimg/flyimg/commit/62fabe8d48003c53cb353f32090840333df1902c) Added PNG support by default. Does not work in combination with enabled webp conversion ### 📊 Changes **3 files changed** (+134 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Controller/CoreController.php` (+2 -1) 📝 `src/Core/Entity/Image.php` (+123 -7) 📝 `src/Core/Service/ImageProcessor.php` (+9 -15) </details> ### 📄 Description Added an identify method but need review. ## Does not work with webP enabled this url `http://192.168.96.100:8080/upload/w_601,h_601,rf_1/https://raw.githubusercontent.com/flyimg/graphic-assets/master/logo/raster/flyimg-logo-rgb.png` will throw `The last line of output: /usr/bin/convert /var/www/html/var/tmp/588fdbd8ec3d38.74595512 -thumbnail 601x601\> -gravity Center -extent 601x601+repage -colorspace sRGB -limit thread '1' -strip -filter 'Lanczos' -sampling-factor '1x1' -quality '90' '/var/www/html/var/tmp/2dd91029ea511b906ac262d82768bd5b-588fdbd8f33cd4.11918861.webp'` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-15 15:39:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#850
No description provided.