[PR #28] [MERGED] Put back exception response for forbidden domains. #845

New issue

Closed

opened 2026-03-15 15:38:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 15:38:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/28
Author: @baamenabar
Created: 1/22/2017
Status: ✅ Merged
Merged: 1/23/2017
Merged by: @sadok-f

Base: master ← Head: forbid-domains

📝 Commits (1)

edd3cad put back exeption response for forbiden domains

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/Core/Controller/DefaultController.php (+2 -0)

📄 Description

I was getting errors when trying to get an image from a restricted domain with restricted_domains: true

See screenshot:

It was allowing the app to try and create a file that was not there. Also trying to get the image's info when requesting with refresh:1 and failing with the previous error.

If the resource was requested without refresh it returned and empty http 200

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/28 **Author:** [@baamenabar](https://github.com/baamenabar) **Created:** 1/22/2017 **Status:** ✅ Merged **Merged:** 1/23/2017 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `master` ← **Head:** `forbid-domains` --- ### 📝 Commits (1) - [`edd3cad`](https://github.com/flyimg/flyimg/commit/edd3cadc9ea747c9f5ce9be76eb7fc502a2557d6) put back exeption response for forbiden domains ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Controller/DefaultController.php` (+2 -0) </details> ### 📄 Description I was getting errors when trying to get an image from a restricted domain with `restricted_domains: true` See screenshot: ![screen shot 2017-01-22 at 22 50 23](https://cloud.githubusercontent.com/assets/836077/22186591/209bfba4-e0f8-11e6-92e7-fb325fc13cdd.png) It was allowing the app to try and create a file that was not there. Also trying to get the image's info when requesting with `refresh:1` and failing with the previous error. If the resource was requested without refresh it returned and empty `http 200` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>