starred/flyimg

Fork 0

mirror of https://github.com/flyimg/flyimg.git synced 2026-04-25 09:45:50 +03:00

[GH-ISSUE #241] Question - I'm adding support for PDF's and Movies in a fork #717

New issue

Closed

opened 2026-03-15 15:09:10 +03:00 by kerem · 9 comments

kerem commented

2026-03-15 15:09:10 +03:00

Owner

Originally created by @louisl on GitHub (Jan 30, 2020).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/241

Originally assigned to: @sadok-f, @baamenabar on GitHub.

Thanks for the repo, it's good work.

I'm working on a fork of this to support PDF's and movie files, are you interested in a PR for it or would you rather me keep it separate?

PDF support (ghostscript) is almost done. It has one new param to choose a page number.

Movie support (ffmpeg) - not started yet. I'm planning to add a param to choose the time mark for to take the image from.

Originally created by @louisl on GitHub (Jan 30, 2020). Original GitHub issue: https://github.com/flyimg/flyimg/issues/241 Originally assigned to: @sadok-f, @baamenabar on GitHub. Thanks for the repo, it's good work. I'm working on a fork of this to support PDF's and movie files, are you interested in a PR for it or would you rather me keep it separate? PDF support (ghostscript) is almost done. It has one new param to choose a page number. Movie support (ffmpeg) - not started yet. I'm planning to add a param to choose the time mark for to take the image from.

kerem

2026-03-15 15:09:10 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-15 15:09:26 +03:00

Author

Owner

@sadok-f commented on GitHub (Jan 31, 2020):

Hi @louisl !

Many thanks for supporting Flyimg project, we'd love to have your new features in our project.

Please create a PR for each feature and we'll be happy to review it and have you in our contributors list.

@sadok-f commented on GitHub (Jan 31, 2020): Hi @louisl ! Many thanks for supporting Flyimg project, we'd love to have your new features in our project. Please create a PR for each feature and we'll be happy to review it and have you in our contributors list.

kerem commented

2026-03-15 15:09:31 +03:00

Author

Owner

@louisl commented on GitHub (Jan 31, 2020):

Hi @sadok-f

As I needed to change things in the same files for both features I closed one PR and did one PR for both features. I did it in a way that wouldn't break backwards compatibility and the changes are fairly minimal. I guess the install of ghostscript and ffmpeg could be optional depending if people wanted these features.

The movie file for tests I got from https://www.sample-videos.com and the pdf I made from a Pages template so no copyright issues.

I'll be putting this in a staging environment for one of my jobs Monday would be nice if it makes it into the core project.

Let me know what you think.

@louisl commented on GitHub (Jan 31, 2020): Hi @sadok-f As I needed to change things in the same files for both features I closed one PR and did one PR for both features. I did it in a way that wouldn't break backwards compatibility and the changes are fairly minimal. I guess the install of ghostscript and ffmpeg could be optional depending if people wanted these features. The movie file for tests I got from https://www.sample-videos.com and the pdf I made from a Pages template so no copyright issues. I'll be putting this in a staging environment for one of my jobs Monday would be nice if it makes it into the core project. Let me know what you think.

kerem commented

2026-03-15 15:09:36 +03:00

Author

Owner

@sadok-f commented on GitHub (Feb 4, 2020):

Hi @louisl !
Thank you for your contribution to Flyimg!
I'm gonna keep the issue open until the link in the documentation got fixed.
For the video you can use the direct link https://www.sample-videos.com/video123/mp4/720/big_buck_bunny_720p_2mb.mp4 instead of https://m0.cl/t/SampleVideo_1280x720_2mb.mp4
Same for the PDF

@sadok-f commented on GitHub (Feb 4, 2020): Hi @louisl ! Thank you for your contribution to Flyimg! I'm gonna keep the issue open until the link in the documentation got fixed. For the video you can use the direct link `https://www.sample-videos.com/video123/mp4/720/big_buck_bunny_720p_2mb.mp4` instead of `https://m0.cl/t/SampleVideo_1280x720_2mb.mp4` Same for the PDF

kerem commented

2026-03-15 15:09:41 +03:00

Author

Owner

@louisl commented on GitHub (Feb 4, 2020):

You're welcome, thanks for the project and your help with the PR.

I'll make the changes to the README, to use the video link, we need to find a hosted PDF or alternatively host the one I made for the tests somewhere. Any suggestions?

@louisl commented on GitHub (Feb 4, 2020): You're welcome, thanks for the project and your help with the PR. I'll make the changes to the README, to use the video link, we need to find a hosted PDF or alternatively host the one I made for the tests somewhere. Any suggestions?

kerem commented

2026-03-15 15:09:46 +03:00

Author

Owner

@sadok-f commented on GitHub (Feb 4, 2020):

I uploaded them to flyimg.io server:

@sadok-f commented on GitHub (Feb 4, 2020): I uploaded them to flyimg.io server: - https://oi.flyimg.io/lighthouses.pdf - https://oi.flyimg.io/big_buck_bunny_720p_2mb.mp4

kerem commented

2026-03-15 15:09:52 +03:00

Author

Owner

@louisl commented on GitHub (Feb 4, 2020):

Both are failing for some reason. I'm out of time right now, will look later tonight.

https://oi.flyimg.io/upload/w_200,h_200,pg_1/https://oi.flyimg.io/lighthouses.pdf
https://oi.flyimg.io/upload/w_200,h_200,tm_00:00:05/https://oi.flyimg.io/big_buck_bunny_720p_2mb.mp4

@louisl commented on GitHub (Feb 4, 2020): Both are failing for some reason. I'm out of time right now, will look later tonight. https://oi.flyimg.io/upload/w_200,h_200,pg_1/https://oi.flyimg.io/lighthouses.pdf https://oi.flyimg.io/upload/w_200,h_200,tm_00:00:05/https://oi.flyimg.io/big_buck_bunny_720p_2mb.mp4

kerem commented

2026-03-15 15:09:57 +03:00

Author

Owner

@sadok-f commented on GitHub (Feb 4, 2020):

My bad I didn't update the docker image on the server, just did now.
It works perfectly!

@sadok-f commented on GitHub (Feb 4, 2020): My bad I didn't update the docker image on the server, just did now. It works perfectly!

kerem commented

2026-03-15 15:10:02 +03:00

Author

Owner

@louisl commented on GitHub (Feb 4, 2020):

No problem, PR #247 should complete this. Thanks again for your help.

@louisl commented on GitHub (Feb 4, 2020): No problem, PR #247 should complete this. Thanks again for your help.

kerem commented

2026-03-15 15:10:07 +03:00

Author

Owner

@sadok-f commented on GitHub (Feb 5, 2020):