[GH-ISSUE #194] Refactor Images entities classes and FaceDetectProcessor #692

Closed
opened 2026-03-15 15:05:19 +03:00 by kerem · 2 comments
Owner

Originally created by @sadok-f on GitHub (Sep 17, 2018).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/194

Originally assigned to: @sadok-f on GitHub.

Currently, we have 2 classes InputImage and OutputImage which they share similar properties, such as path, mimeType, info,...

It'll a good choice to refactor those 2 classes and create one abstract class BaseImage that extensible by the InputImage and OutputImage.

This will give us the choice to use the OutputImage as InputImage again in the ImageHandler, it'll solve many issues we have currently, especially in the FacetDetection process.
Which need to be rewritten after creating a BaseImage.

Originally created by @sadok-f on GitHub (Sep 17, 2018). Original GitHub issue: https://github.com/flyimg/flyimg/issues/194 Originally assigned to: @sadok-f on GitHub. Currently, we have 2 classes `InputImage` and `OutputImage` which they share similar properties, such as path, mimeType, info,... It'll a good choice to refactor those 2 classes and create one abstract class `BaseImage` that extensible by the `InputImage` and `OutputImage`. This will give us the choice to use the `OutputImage` as `InputImage` again in the `ImageHandler`, it'll solve many issues we have currently, especially in the `FacetDetection` process. Which need to be rewritten after creating a `BaseImage`.
kerem 2026-03-15 15:05:19 +03:00
Author
Owner

@github-actions[bot] commented on GitHub (Aug 26, 2023):

This issue is stale because it has been open for 30 days with no activity.

<!-- gh-comment-id:1694113917 --> @github-actions[bot] commented on GitHub (Aug 26, 2023): This issue is stale because it has been open for 30 days with no activity.
Author
Owner

@github-actions[bot] commented on GitHub (Sep 9, 2023):

This issue was closed because it has been inactive for 14 days since being marked as stale.

<!-- gh-comment-id:1712384210 --> @github-actions[bot] commented on GitHub (Sep 9, 2023): This issue was closed because it has been inactive for 14 days since being marked as stale.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#692
No description provided.