starred/flyimg
1
0
Fork 0
mirror of https://github.com/flyimg/flyimg.git synced 2026-04-25 01:35:56 +03:00
Code Issues Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #191] Image path parameters is ignored #690

New issue
Closed
opened 2026-03-15 15:04:32 +03:00 by kerem · 6 comments
kerem commented 2026-03-15 15:04:32 +03:00
Owner
Copy link

Originally created by @yoldar on GitHub (Sep 13, 2018).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/191

Originally assigned to: @sadok-f on GitHub.

Hi guys!

Is that possible to not ignore image path parameters?

When I try this in container:
curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg?token=342342342334&someParam=dlklksfdldf

I got error:

Error occurred while trying to read the file Url : http://some.com/uploads/image.jpg

Download image in container with regular wget works normal.

wget http://some.com/uploads/image.jpg?token=342342342334&someParam=dlklksfdldf is ok

P.s. I really need this because downloading images can only be with access params like token and so on.

Originally created by @yoldar on GitHub (Sep 13, 2018). Original GitHub issue: https://github.com/flyimg/flyimg/issues/191 Originally assigned to: @sadok-f on GitHub. Hi guys! Is that possible to not ignore image path parameters? When I try this in container: `curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg?token=342342342334&someParam=dlklksfdldf` I got error: > Error occurred while trying to read the file Url : http://some.com/uploads/image.jpg Download image in container with regular wget works normal. > wget http://some.com/uploads/image.jpg?token=342342342334&someParam=dlklksfdldf is ok P.s. I really need this because downloading images can only be with access params like token and so on.
kerem commented 2026-03-15 15:04:49 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Sep 13, 2018):

Hi @yoldar !

The problem is with ? which will convert the token into a parameter GET in the flyimg application, maybe if you try to encode it before pass it to flyimg server:

curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg%3Ftoken=342342342334

<!-- gh-comment-id:421067175 --> @sadok-f commented on GitHub (Sep 13, 2018): Hi @yoldar ! The problem is with `?` which will convert the token into a parameter GET in the flyimg application, maybe if you try to encode it before pass it to flyimg server: `curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg%3Ftoken=342342342334`
kerem commented 2026-03-15 15:04:54 +03:00
Author
Owner
Copy link

@yoldar commented on GitHub (Sep 14, 2018):

Hi @yoldar !

The problem is with ? which will convert the token into a parameter GET in the flyimg application, maybe if you try to encode it before pass it to flyimg server:

curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg%3Ftoken=342342342334

Thanks!

<!-- gh-comment-id:421250848 --> @yoldar commented on GitHub (Sep 14, 2018): > Hi @yoldar ! > > The problem is with `?` which will convert the token into a parameter GET in the flyimg application, maybe if you try to encode it before pass it to flyimg server: > > `curl "http://localhost/upload/w_500,h_500,q_90/http://some.com/uploads/image.jpg%3Ftoken=342342342334` Thanks!
kerem commented 2026-03-15 15:04:59 +03:00
Author
Owner
Copy link

@yoldar commented on GitHub (Sep 14, 2018):

@sadok-f

Could you please advice is that possible to ignore all parameters when making hash naming for original and optimized files? I mean original-HASH than stored under "tmp" folder and HASH.webp under "uploads" folder?

P.s. Because access token changes every time but image still the same.

<!-- gh-comment-id:421264028 --> @yoldar commented on GitHub (Sep 14, 2018): @sadok-f Could you please advice is that possible to ignore all parameters when making hash naming for original and optimized files? I mean original-HASH than stored under "tmp" folder and HASH.webp under "uploads" folder? P.s. Because access token changes every time but image still the same.
kerem commented 2026-03-15 15:05:04 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Sep 14, 2018):

@yoldar Thanks for pointing this out, in fact, the original image should be saved without considering any extras arguments, so the hash should be generated only with the image source URL.
I'll work on it this weekend and hopefully submit a PR regarding that!

Thank you again!

<!-- gh-comment-id:421472382 --> @sadok-f commented on GitHub (Sep 14, 2018): @yoldar Thanks for pointing this out, in fact, the original image should be saved without considering any extras arguments, so the hash should be generated only with the image source URL. I'll work on it this weekend and hopefully submit a PR regarding that! Thank you again!
kerem commented 2026-03-15 15:05:09 +03:00
Author
Owner
Copy link

@yoldar commented on GitHub (Sep 16, 2018):

Thanks! It would be great!
P.s. Open source rulez! 😁

<!-- gh-comment-id:421749264 --> @yoldar commented on GitHub (Sep 16, 2018): Thanks! It would be great! P.s. Open source rulez! 😁
kerem commented 2026-03-15 15:05:14 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Sep 16, 2018):

Here we go

<!-- gh-comment-id:421751775 --> @sadok-f commented on GitHub (Sep 16, 2018): Here we go
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
add-trendshift-badge
gh-pages
issue#547
issue#546
issue#448
1.12.0
1.11.0
1.10.3
1.10.2
1.10.1
1.10.0
1.9.1
1.9.0
1.8.1
1.8.0
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.58
1.1.57
1.1.56
1.1.55
1.1.54
1.1.53
1.1.52
1.1.51
1.1.50
1.1.49
1.1.48
1.1.47
1.1.46
1.1.45
1.1.44
1.1.43
1.1.42
1.1.41
1.1.40
1.1.39
1.1.38
1.1.37
1.1.36
1.1.35
1.1.34
1.1.33
1.1.32
1.1.31
1.1.30
1.1.29
1.1.28
1.1.27
1.1.26
1.1.25
1.1.24
1.1.23
1.1.22
1.1.21
1.1.20
1.1.19
1.1.18
1.1.17
1.1.16
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.2.0
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
Labels
Clear labels   
Docs

   
Docs

   
Docs

   
Security

   
UnitTest

   
bug

   
dependencies

   
duplicate

   
enhancement

   
enhancement

   
enhancement

   
hacktoberfest

   
help wanted

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
stale

   
version 1

   
version 2

   
wontfix
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#690
No description provided.