mirror of
https://github.com/flyimg/flyimg.git
synced 2026-04-25 09:45:50 +03:00
[GH-ISSUE #169] Output auto problem #682
Labels
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flyimg#682
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @martinbertinat on GitHub (Aug 2, 2018).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/169
Hi all, first of all thanks for the great work.
I'm having problems with the auto output feature. If your input file is a jpg file, you navigate to the url to compress it in Chrome (for example) and then you save it to your disk and try to open it, you will see an error because the image is a webp and the extension is .jpg so the software in which you open the file is trying to open the image as .jpg and can't process it. I know this is not the main use case, but it is giving me problems with iphones
So, I try with the option "o_input" but I get another error:
Attempted to call an undefined method named "inputImageExtension" of class "Core\Entity\Image\OutputImage".
Did you mean to call "getOutputImageExtension"?
Clearly the method inputImageExtension is called and does not exist!
Let me know If I can fix this!
Thanks
@sadok-f commented on GitHub (Aug 2, 2018):
Hi @martinbertinat !
Thank you for submitting the issue!
Regarding the error :
undefined method named "inputImageExtension"Obviously, it's a bug and we need to fix it, I assume it was introduced during the last changes we did (Code cleanup -_- by me).
We need to add a test for this case also.
For the jpeg output which was generated as webp, I'll check that also.
If you want to help, you're welcome of course, the extension generation is done in
Entity/Image/OutputImage.php::generateFileExtensionfunction