[GH-ISSUE #96] [RFC] Add signature generation #36

Closed
opened 2026-02-25 22:34:12 +03:00 by kerem · 1 comment
Owner

Originally created by @joelwurtz on GitHub (Jul 10, 2017).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/96

Originally assigned to: @sadok-f on GitHub.

Hey,

Didn't find this in the doc, but maybe it's already implemented ?

Goal of this RFC is to be able to use flyimg as a public hosting media (no domain restriction) but still provides security to avoid "bad" users to generate their owns image (like doing a loop with +1 pixel width) and doing a DDOS attack.

A way to achieve that is to have on the page creating the url to this service, and on flyimage a shared key whichs allows to encode all the parameters with the url into a signature, and check this on the server (if signature invalid throw a 403 / 404 ?). It's very similar on how thumbor works.

WDYT ?

Originally created by @joelwurtz on GitHub (Jul 10, 2017). Original GitHub issue: https://github.com/flyimg/flyimg/issues/96 Originally assigned to: @sadok-f on GitHub. Hey, Didn't find this in the doc, but maybe it's already implemented ? Goal of this RFC is to be able to use flyimg as a public hosting media (no domain restriction) but still provides security to avoid "bad" users to generate their owns image (like doing a loop with +1 pixel width) and doing a DDOS attack. A way to achieve that is to have on the page creating the url to this service, and on flyimage a shared key whichs allows to encode all the parameters with the url into a signature, and check this on the server (if signature invalid throw a 403 / 404 ?). It's very similar on how thumbor works. WDYT ?
kerem 2026-02-25 22:34:12 +03:00
Author
Owner

@sadok-f commented on GitHub (Jul 11, 2017):

@joelwurtz Indeed this PR is a must have on Flyimg.
Currently, only the restricted domains are the only the security layer, the server could fail with DDOS.
I checked Thumbor implementation
https://github.com/thumbor/thumbor/wiki/Security
Very straightforward and simple to implement, We hope we can add this soon.
Many thanks for raising this topic.

<!-- gh-comment-id:314360951 --> @sadok-f commented on GitHub (Jul 11, 2017): @joelwurtz Indeed this PR is a must have on Flyimg. Currently, only the restricted domains are the only the security layer, the server could fail with DDOS. I checked Thumbor implementation https://github.com/thumbor/thumbor/wiki/Security Very straightforward and simple to implement, We hope we can add this soon. Many thanks for raising this topic.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#36
No description provided.