[PR #244] [MERGED] Louisl/feature/movie support, closes #243 #350

Closed
opened 2026-02-25 22:35:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/244
Author: @sadok-f
Created: 2/4/2020
Status: Merged
Merged: 2/4/2020
Merged by: @sadok-f

Base: masterHead: louisl/feature/movie-support


📝 Commits (10+)

  • 64e528d Added ghostscript
  • 63e02e7 Added PDF mimetype and isInputPdf function
  • 488ee6a If it's a pdf use pgae no param
  • a640a69 Added pg param for PDF
  • 5ac06b3 Changed parameter name to be more generic, appends page number to cached image
  • 621580e Added movie support
  • 1a6c2bd Fixed current unit tests
  • f57ea1b code style
  • e86fb59 Cleaned up and added and exception if the time is out of range
  • cbe1b0e Commenting and a little refactor

📊 Changes

16 files changed (+272 additions, -56 deletions)

View changed files

📝 Dockerfile (+4 -1)
📝 config/parameters.yml (+4 -0)
📝 src/Core/Entity/Image/InputImage.php (+56 -11)
📝 src/Core/Entity/Image/OutputImage.php (+29 -19)
📝 src/Core/Entity/ImageMetaInfo.php (+1 -1)
📝 src/Core/Handler/ImageHandler.php (+4 -4)
📝 src/Core/Processor/ImageProcessor.php (+8 -3)
📝 src/Core/Processor/Processor.php (+3 -0)
src/Core/Processor/VideoProcessor.php (+61 -0)
📝 tests/Core/BaseTest.php (+7 -1)
📝 tests/Core/Controller/DefaultControllerTest.php (+77 -0)
📝 tests/Core/Entity/Image/OutputImageTest.php (+2 -0)
📝 tests/Core/Entity/ImageMetaInfoTest.php (+7 -7)
📝 tests/Core/Handler/ImageHandlerTest.php (+9 -9)
tests/testImages/SampleVideo_1280x720_2mb.mp4 (+0 -0)
tests/testImages/lighthouses.pdf (+0 -0)

📄 Description

Followup PR to #243


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/244 **Author:** [@sadok-f](https://github.com/sadok-f) **Created:** 2/4/2020 **Status:** ✅ Merged **Merged:** 2/4/2020 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `master` ← **Head:** `louisl/feature/movie-support` --- ### 📝 Commits (10+) - [`64e528d`](https://github.com/flyimg/flyimg/commit/64e528d9b280fbf5a23888779c0925ec799a3f2e) Added ghostscript - [`63e02e7`](https://github.com/flyimg/flyimg/commit/63e02e71d0a7cfa3da29af25426702911e277dfd) Added PDF mimetype and isInputPdf function - [`488ee6a`](https://github.com/flyimg/flyimg/commit/488ee6a8242b05b3f6438dfa89b1f09acebce61f) If it's a pdf use pgae no param - [`a640a69`](https://github.com/flyimg/flyimg/commit/a640a6983a602343acd60b38bb5e62d72a1b1f7f) Added pg param for PDF - [`5ac06b3`](https://github.com/flyimg/flyimg/commit/5ac06b3f459a9060d8c656245d3b375048613a49) Changed parameter name to be more generic, appends page number to cached image - [`621580e`](https://github.com/flyimg/flyimg/commit/621580e84064f66fe6cce309b7d1c3dd2759514d) Added movie support - [`1a6c2bd`](https://github.com/flyimg/flyimg/commit/1a6c2bdcf085ce0b23f0f88876904e6ad4bdedf4) Fixed current unit tests - [`f57ea1b`](https://github.com/flyimg/flyimg/commit/f57ea1bfe7ee96cd27f5b952e7d55c96949eca12) code style - [`e86fb59`](https://github.com/flyimg/flyimg/commit/e86fb592101af5a9d05f9e345cee23d8e16bf41f) Cleaned up and added and exception if the time is out of range - [`cbe1b0e`](https://github.com/flyimg/flyimg/commit/cbe1b0efbd82a849ffc9c399101024041fd2178e) Commenting and a little refactor ### 📊 Changes **16 files changed** (+272 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+4 -1) 📝 `config/parameters.yml` (+4 -0) 📝 `src/Core/Entity/Image/InputImage.php` (+56 -11) 📝 `src/Core/Entity/Image/OutputImage.php` (+29 -19) 📝 `src/Core/Entity/ImageMetaInfo.php` (+1 -1) 📝 `src/Core/Handler/ImageHandler.php` (+4 -4) 📝 `src/Core/Processor/ImageProcessor.php` (+8 -3) 📝 `src/Core/Processor/Processor.php` (+3 -0) ➕ `src/Core/Processor/VideoProcessor.php` (+61 -0) 📝 `tests/Core/BaseTest.php` (+7 -1) 📝 `tests/Core/Controller/DefaultControllerTest.php` (+77 -0) 📝 `tests/Core/Entity/Image/OutputImageTest.php` (+2 -0) 📝 `tests/Core/Entity/ImageMetaInfoTest.php` (+7 -7) 📝 `tests/Core/Handler/ImageHandlerTest.php` (+9 -9) ➕ `tests/testImages/SampleVideo_1280x720_2mb.mp4` (+0 -0) ➕ `tests/testImages/lighthouses.pdf` (+0 -0) </details> ### 📄 Description Followup PR to #243 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 22:35:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#350
No description provided.