[PR #237] [MERGED] Fixing FaceDetect not working, closes #236 #344

New issue

Closed

opened 2026-02-25 22:35:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 22:35:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/237
Author: @sadok-f
Created: 12/2/2019
Status: ✅ Merged
Merged: 12/3/2019
Merged by: @sadok-f

Base: master ← Head: issue#236

📝 Commits (9)

98f9a0a Fixing FaceDetect not working, closes #236
9b9dc5b Fixing Unit Test, closes #236
ed6b601 Rounding up the comparing results, closes #236
8677a1e Fixinf unit tests , closes #236
33082ae Refactor the image comparision logic for the unit tests, closes #236
1dddde4 Debuging unit test in Travis CI, issue#236
8f45640 Debug file size for unit test, issue#236
d9d3bbd Add png output image for unit test
6c7f83b Switching to compare generated file size, closes #236

📊 Changes

9 files changed (+31 additions, -29 deletions)

View changed files

📝 src/Core/Handler/ImageHandler.php (+4 -3)
📝 src/Core/Processor/FaceDetectProcessor.php (+10 -10)
📝 tests/Core/BaseTest.php (+2 -2)
📝 tests/Core/Processor/ExtractProcessorTest.php (+3 -4)
📝 tests/Core/Processor/FaceDetectProcessorTest.php (+12 -10)
📝 tests/testImages/face_cp0.jpg (+0 -0)
➕ tests/testImages/face_cp0.png (+0 -0)
📝 tests/testImages/face_fb.jpg (+0 -0)
➕ tests/testImages/face_fb.png (+0 -0)

📄 Description

I moved the logic for the Face Detection (Crop and Blur) just after the resizing process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/237 **Author:** [@sadok-f](https://github.com/sadok-f) **Created:** 12/2/2019 **Status:** ✅ Merged **Merged:** 12/3/2019 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `master` ← **Head:** `issue#236` --- ### 📝 Commits (9) - [`98f9a0a`](https://github.com/flyimg/flyimg/commit/98f9a0a378d2d641b488fc910b28d39840403ab3) Fixing FaceDetect not working, closes #236 - [`9b9dc5b`](https://github.com/flyimg/flyimg/commit/9b9dc5b08d8d679d01d96c5b7bdb1d021eca33d7) Fixing Unit Test, closes #236 - [`ed6b601`](https://github.com/flyimg/flyimg/commit/ed6b6019ee605fd3c4326defcbb38fd1f536a321) Rounding up the comparing results, closes #236 - [`8677a1e`](https://github.com/flyimg/flyimg/commit/8677a1e388f0f243da5287d311e319a3e804e08b) Fixinf unit tests , closes #236 - [`33082ae`](https://github.com/flyimg/flyimg/commit/33082ae5e1a54be0d6b1b9f3bacb5b528e970f66) Refactor the image comparision logic for the unit tests, closes #236 - [`1dddde4`](https://github.com/flyimg/flyimg/commit/1dddde433edefbfbc790678492134c6f3d675eab) Debuging unit test in Travis CI, issue#236 - [`8f45640`](https://github.com/flyimg/flyimg/commit/8f45640de7bb107f4711cf8d2f07a74c956328e5) Debug file size for unit test, issue#236 - [`d9d3bbd`](https://github.com/flyimg/flyimg/commit/d9d3bbd8898131cb80eec3239f9ee00b19aed5dd) Add png output image for unit test - [`6c7f83b`](https://github.com/flyimg/flyimg/commit/6c7f83bd80ab0643354a68ce9d1d7be6d1e16aa8) Switching to compare generated file size, closes #236 ### 📊 Changes **9 files changed** (+31 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Handler/ImageHandler.php` (+4 -3) 📝 `src/Core/Processor/FaceDetectProcessor.php` (+10 -10) 📝 `tests/Core/BaseTest.php` (+2 -2) 📝 `tests/Core/Processor/ExtractProcessorTest.php` (+3 -4) 📝 `tests/Core/Processor/FaceDetectProcessorTest.php` (+12 -10) 📝 `tests/testImages/face_cp0.jpg` (+0 -0) ➕ `tests/testImages/face_cp0.png` (+0 -0) 📝 `tests/testImages/face_fb.jpg` (+0 -0) ➕ `tests/testImages/face_fb.png` (+0 -0) </details> ### 📄 Description I moved the logic for the Face Detection (Crop and Blur) just after the resizing process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>