starred/flyimg
1
0
Fork 0
mirror of https://github.com/flyimg/flyimg.git synced 2026-04-25 09:45:50 +03:00
Code Issues Projects Releases 10 Packages Wiki Activity

[PR #130] [MERGED] Image Processor geometry refactor. #295

New issue
Closed
opened 2026-02-25 22:35:00 +03:00 by kerem · 0 comments
kerem commented 2026-02-25 22:35:00 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/130
Author: @baamenabar
Created: 9/10/2017
Status: ✅ Merged
Merged: 9/18/2017
Merged by: @baamenabar

Base: master ← Head: im-geometry-refactor

📝 Commits (9)

  • e18722e Added test cases to ImageMetaInfo class unit test suite.
  • f669a97 [WIP] First steps into refactoring the geometry calculations. Adding tests.
  • e8547f6 Merge branch 'master' into im-geometry-refactor
  • 9e7bd58 Separated method for very basic, most common resizing operations.
  • 14270c9 Preventing resized images from being expanded if preserve-natural-size is active
  • 4b6348e Added behaviour to resize with crop option. Most test passing now.
  • 725947c Updated and added tests cases for expanding images without stretching. Added cases for partial croping to the sides or top and bottom.
  • a82836f Initial cleanup after refactor, moved ImageMetaInfo one level up
  • 9e4c19f Cleanup of the tests code. Code climate finds it too repetitive.

📊 Changes

6 files changed (+356 additions, -46 deletions)

View changed files

📝 src/Core/Entity/Image/InputImage.php (+6 -1)
📝 src/Core/Entity/ImageMetaInfo.php (+1 -1)
📝 src/Core/Entity/OptionsBag.php (+34 -0)
📝 src/Core/Processor/ImageProcessor.php (+161 -35)
📝 tests/Core/Entity/ImageMetaInfoTest.php (+2 -3)
📝 tests/Core/Processor/ImageProcessorTest.php (+152 -6)

📄 Description

this is just the first steps, the failing tests, I'll start the actual refactor after this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/130 **Author:** [@baamenabar](https://github.com/baamenabar) **Created:** 9/10/2017 **Status:** ✅ Merged **Merged:** 9/18/2017 **Merged by:** [@baamenabar](https://github.com/baamenabar) **Base:** `master` ← **Head:** `im-geometry-refactor` --- ### 📝 Commits (9) - [`e18722e`](https://github.com/flyimg/flyimg/commit/e18722e4eea6a893d3367c1134da68ff139dd912) Added test cases to ImageMetaInfo class unit test suite. - [`f669a97`](https://github.com/flyimg/flyimg/commit/f669a971b5bc0fa54b9452a0491093683367a256) [WIP] First steps into refactoring the geometry calculations. Adding tests. - [`e8547f6`](https://github.com/flyimg/flyimg/commit/e8547f6096e29aaa38671c475e97d5aaf6798170) Merge branch 'master' into im-geometry-refactor - [`9e7bd58`](https://github.com/flyimg/flyimg/commit/9e7bd58c0c91b3c3994974a9bb03477c6e6992f2) Separated method for very basic, most common resizing operations. - [`14270c9`](https://github.com/flyimg/flyimg/commit/14270c9cede33ab27b17a3ec8efaf7c5d93cdfbc) Preventing resized images from being expanded if preserve-natural-size is active - [`4b6348e`](https://github.com/flyimg/flyimg/commit/4b6348ebdfd4aabea82f4c08dcb9358576951ea3) Added behaviour to resize with crop option. Most test passing now. - [`725947c`](https://github.com/flyimg/flyimg/commit/725947c246e9b208f82035931eb9d002cb7ee0ee) Updated and added tests cases for expanding images without stretching. Added cases for partial croping to the sides or top and bottom. - [`a82836f`](https://github.com/flyimg/flyimg/commit/a82836f1b4e0d053cfc0e2a4da099d61d65cdf6e) Initial cleanup after refactor, moved ImageMetaInfo one level up - [`9e4c19f`](https://github.com/flyimg/flyimg/commit/9e4c19f9fd9da60b24b94d264edd87d35a4998cf) Cleanup of the tests code. Code climate finds it too repetitive. ### 📊 Changes **6 files changed** (+356 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Entity/Image/InputImage.php` (+6 -1) 📝 `src/Core/Entity/ImageMetaInfo.php` (+1 -1) 📝 `src/Core/Entity/OptionsBag.php` (+34 -0) 📝 `src/Core/Processor/ImageProcessor.php` (+161 -35) 📝 `tests/Core/Entity/ImageMetaInfoTest.php` (+2 -3) 📝 `tests/Core/Processor/ImageProcessorTest.php` (+152 -6) </details> ### 📄 Description this is just the first steps, the failing tests, I'll start the actual refactor after this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 22:35:00 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
add-trendshift-badge
gh-pages
issue#547
issue#546
issue#448
1.12.0
1.11.0
1.10.3
1.10.2
1.10.1
1.10.0
1.9.1
1.9.0
1.8.1
1.8.0
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.58
1.1.57
1.1.56
1.1.55
1.1.54
1.1.53
1.1.52
1.1.51
1.1.50
1.1.49
1.1.48
1.1.47
1.1.46
1.1.45
1.1.44
1.1.43
1.1.42
1.1.41
1.1.40
1.1.39
1.1.38
1.1.37
1.1.36
1.1.35
1.1.34
1.1.33
1.1.32
1.1.31
1.1.30
1.1.29
1.1.28
1.1.27
1.1.26
1.1.25
1.1.24
1.1.23
1.1.22
1.1.21
1.1.20
1.1.19
1.1.18
1.1.17
1.1.16
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.2.0
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
Labels
Clear labels   
Docs

   
Docs

   
Docs

   
Security

   
UnitTest

   
bug

   
dependencies

   
duplicate

   
enhancement

   
enhancement

   
enhancement

   
hacktoberfest

   
help wanted

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
stale

   
version 1

   
version 2

   
wontfix
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#295
No description provided.