mirror of
https://github.com/flyimg/flyimg.git
synced 2026-04-25 09:45:50 +03:00
[GH-ISSUE #590] Make access_id and secret_key optional for IRSA S3 access support #213
Labels
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flyimg#213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yo-l1982 on GitHub (Oct 16, 2025).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/590
Originally assigned to: @sadok-f on GitHub.
Is your feature request related to a problem? Please describe.
In EKS we use IRSA to access buckets.
It is a no key/secret access method were the container uses a ServiceAccount connected to a IAM role that will inject what is needed for the AWS SDK to access the bucket.
Describe the solution you'd like
Make access_id and secret_key optional as they are now enforced by validation.
When these two parameters are set and passed into the AWS SDK client the key/secret access method will take precedence over IRSA. Any dummy key/secret will return a 403 from AWS API.
I have tried this with a custom build of flyimg and it works, I can deliver a PR, it is a really simple fix.
As seen below flyimg is already using supported AWS SDK versions
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html
Additional context
I believe this also will add support for "Pod identities" in EKS
https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html
It will probably also add support for similar solutions in Azure and GCP but I am in no possition to test this.
@sadok-f commented on GitHub (Oct 17, 2025):
Hi @yo-l1982
thank you for opening this issue.
yes I understand what you mean here.
we'll work to update the functionality asap.
Thank you again!
@sadok-f commented on GitHub (Oct 19, 2025):
@yo-l1982 we’ve just released version 1.9.1, which includes updates to support the IRSA feature.
Thank you!