starred/flyimg
1
0
Fork 0
mirror of https://github.com/flyimg/flyimg.git synced 2026-04-25 09:45:50 +03:00
Code Issues Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #481] Special Characters in urls #177

New issue
Closed
opened 2026-02-25 22:34:32 +03:00 by kerem · 6 comments
kerem commented 2026-02-25 22:34:32 +03:00
Owner
Copy link

Originally created by @TimWeyand on GitHub (Jul 26, 2024).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/481

Originally assigned to: @sadok-f on GitHub.

Describe the bug
If the source image has a special character in the url, the operation results in an Exception in /src/Core/Entity/Image/InputImage.php:114 . Its technically not wanted to have special characters like a space, but non technical personal, sometimes upload it anyways

To Reproduce
load an image with an special character like %20 (space). In php it will be converted to " ", which causes the error.

Expected behavior
parts of the url previously url encoded, should be url encoded on the way out.

Originally created by @TimWeyand on GitHub (Jul 26, 2024). Original GitHub issue: https://github.com/flyimg/flyimg/issues/481 Originally assigned to: @sadok-f on GitHub. **Describe the bug** If the source image has a special character in the url, the operation results in an Exception in /src/Core/Entity/Image/InputImage.php:114 . Its technically not wanted to have special characters like a space, but non technical personal, sometimes upload it anyways **To Reproduce** load an image with an special character like %20 (space). In php it will be converted to " ", which causes the error. **Expected behavior** parts of the url previously url encoded, should be url encoded on the way out.
kerem 2026-02-25 22:34:32 +03:00
  • closed this issue
  • added the
    bug
         label
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Jul 26, 2024):

Thank you @TimWeyand for reporting this issue.
I'll check it out and get back to you.

<!-- gh-comment-id:2252812499 --> @sadok-f commented on GitHub (Jul 26, 2024): Thank you @TimWeyand for reporting this issue. I'll check it out and get back to you.
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Jul 28, 2024):

Hi @TimWeyand could you please provide more details about the issue?
Ideally, it should be a concrete example of an image URL with a special character.
Flyimg should handle URL encoded source images, as some source endpoint require some parameters.
Here my testing of a local image with space encoded (%20):
image

<!-- gh-comment-id:2254458733 --> @sadok-f commented on GitHub (Jul 28, 2024): Hi @TimWeyand could you please provide more details about the issue? Ideally, it should be a concrete example of an image URL with a special character. Flyimg should handle URL encoded source images, as some source endpoint require some parameters. Here my testing of a local image with space encoded (%20): ![image](https://github.com/user-attachments/assets/a3d5c8d5-13e0-4c26-8442-46c7fb36b7e3)
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@TimWeyand commented on GitHub (Jul 28, 2024):

Hi @sadok-f,
thank you for checking this issue! 🙂

Here are three examples (one working control - two not working examples):

Working request:
control:

curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/controll.png

HTTP/2 200
last-modified: Sun, 28 Jul 2024 14:29:21 GMT
etag: "c2ef0c5cc7449d3b9c0731cca17d0132"
content-type: image/png
accept-ranges: bytes
removed headers

flyimg:

curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/controll.png
HTTP/2 200
date: Sun, 28 Jul 2024 14:30:38 GMT
content-type: image/avif
content-length: 158431
cache-control: public, max-age=31536000, s-maxage=31536000
removed headers

Just Spaces (failed) request:
control:

curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/Bildschirmfoto%202024%2007%2028%20um%2015%2046%2028.png
HTTP/2 200
last-modified: Sun, 28 Jul 2024 13:50:03 GMT
etag: "c2ef0c5cc7449d3b9c0731cca17d0132"
content-type: image/png
accept-ranges: bytes
removed headers

flyimg:

curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/Bildschirmfoto%202024%2007%2028%20um%2015%2046%2028.png
HTTP/2 500
date: Sun, 28 Jul 2024 14:34:13 GMT
content-type: text/html; charset=UTF-8
cache-control: private, must-revalidate
pragma: no-cache
removed headers

Just weird filename:
control:

curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/justwéird-śtüff.png
HTTP/2 200
last-modified: Sun, 28 Jul 2024 14:28:44 GMT
etag: "c2ef0c5cc7449d3b9c0731cca17d0132"
content-type: image/png
accept-ranges: bytes
age: 117
date: Sun, 28 Jul 2024 14:37:53 GMT

flyimg:

curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/justwéird-śtüff.png
HTTP/2 500
date: Sun, 28 Jul 2024 14:40:55 GMT
content-type: text/html; charset=UTF-8
cache-control: private, must-revalidate
pragma: no-cache
expires: -1
cf-cache-status: BYPASS
removed headers

<!-- gh-comment-id:2254543389 --> @TimWeyand commented on GitHub (Jul 28, 2024): Hi @sadok-f, thank you for checking this issue! 🙂 Here are three examples (one working control - two not working examples): Working request: control: > curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/controll.png > > HTTP/2 200 > last-modified: Sun, 28 Jul 2024 14:29:21 GMT > etag: "c2ef0c5cc7449d3b9c0731cca17d0132" > content-type: image/png > accept-ranges: bytes > *removed headers* flyimg: > curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/controll.png > HTTP/2 200 > date: Sun, 28 Jul 2024 14:30:38 GMT > content-type: image/avif > content-length: 158431 > cache-control: public, max-age=31536000, s-maxage=31536000 > *removed headers* Just Spaces (failed) request: control: > curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/Bildschirmfoto%202024%2007%2028%20um%2015%2046%2028.png > HTTP/2 200 > last-modified: Sun, 28 Jul 2024 13:50:03 GMT > etag: "c2ef0c5cc7449d3b9c0731cca17d0132" > content-type: image/png > accept-ranges: bytes > *removed headers* flyimg: > curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/Bildschirmfoto%202024%2007%2028%20um%2015%2046%2028.png > HTTP/2 500 > date: Sun, 28 Jul 2024 14:34:13 GMT > content-type: text/html; charset=UTF-8 > cache-control: private, must-revalidate > pragma: no-cache > *removed headers* Just weird filename: control: > curl -I https://cdn.klambt.services/_trash/testing/screen/flyimg/justwéird-śtüff.png > HTTP/2 200 > last-modified: Sun, 28 Jul 2024 14:28:44 GMT > etag: "c2ef0c5cc7449d3b9c0731cca17d0132" > content-type: image/png > accept-ranges: bytes > age: 117 > date: Sun, 28 Jul 2024 14:37:53 GMT flyimg: > curl -I https://demo.flyimg.io/upload/q_85/https://cdn.klambt.services/_trash/testing/screen/flyimg/justwéird-śtüff.png > HTTP/2 500 > date: Sun, 28 Jul 2024 14:40:55 GMT > content-type: text/html; charset=UTF-8 > cache-control: private, must-revalidate > pragma: no-cache > expires: -1 > cf-cache-status: BYPASS > *removed headers*
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@TimWeyand commented on GitHub (Aug 5, 2024):

@sadok-f I have added an (unpretty) method to rawurlencode() parts of the url which could cause problems.

<!-- gh-comment-id:2269231116 --> @TimWeyand commented on GitHub (Aug 5, 2024): @sadok-f I have added an (unpretty) method to rawurlencode() parts of the url which could cause problems.
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Aug 12, 2024):

Sorry @TimWeyand for not answering you, I'm currently on vacation until the end of August.
As soon as I get back I will check it out.
Thank you.

<!-- gh-comment-id:2283215245 --> @sadok-f commented on GitHub (Aug 12, 2024): Sorry @TimWeyand for not answering you, I'm currently on vacation until the end of August. As soon as I get back I will check it out. Thank you.
kerem commented 2026-02-25 22:34:32 +03:00
Author
Owner
Copy link

@sadok-f commented on GitHub (Aug 27, 2024):

fixed in #483

<!-- gh-comment-id:2311839516 --> @sadok-f commented on GitHub (Aug 27, 2024): fixed in #483
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
add-trendshift-badge
gh-pages
issue#547
issue#546
issue#448
1.12.0
1.11.0
1.10.3
1.10.2
1.10.1
1.10.0
1.9.1
1.9.0
1.8.1
1.8.0
1.7.11
1.7.10
1.7.9
1.7.8
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.0
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.9
1.2.8
1.2.7
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.58
1.1.57
1.1.56
1.1.55
1.1.54
1.1.53
1.1.52
1.1.51
1.1.50
1.1.49
1.1.48
1.1.47
1.1.46
1.1.45
1.1.44
1.1.43
1.1.42
1.1.41
1.1.40
1.1.39
1.1.38
1.1.37
1.1.36
1.1.35
1.1.34
1.1.33
1.1.32
1.1.31
1.1.30
1.1.29
1.1.28
1.1.27
1.1.26
1.1.25
1.1.24
1.1.23
1.1.22
1.1.21
1.1.20
1.1.19
1.1.18
1.1.17
1.1.16
1.1.15
1.1.14
1.1.13
1.1.12
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.2.0
0.1.9
0.1.8
0.1.7
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
Labels
Clear labels   
Docs

   
Docs

   
Docs

   
Security

   
UnitTest

   
bug

   
dependencies

   
duplicate

   
enhancement

   
enhancement

   
enhancement

   
hacktoberfest

   
help wanted

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
stale

   
version 1

   
version 2

   
wontfix
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/flyimg#177
No description provided.