mirror of
https://github.com/flyimg/flyimg.git
synced 2026-04-25 09:45:50 +03:00
[GH-ISSUE #449] Parameters.yml file not working #166
Labels
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flyimg#166
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Joonas12334 on GitHub (May 21, 2024).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/449
Originally assigned to: @sadok-f on GitHub.
When using docker to map parameters.yml file it just won't be read.
I'm using this docker compose file:
version: '3.8'
services:
flyimg:
image: flyimg/flyimg
container_name: flyimg-container
ports:
- "8087:80" # Map port 8080 on the host to port 80 in the container
volumes:
- /volume1/docker/flyimg/parameters.yml:/var/www/html/config/parameters.yml
restart: unless-stopped
@Joonas12334 commented on GitHub (May 21, 2024):
Update: The file does work. Partially at least. Found out from the log files that the heic_speed variable works well. It's the options_separator that's giving me a headache. That's the whole error code on website when changing separator to "+" for example "Error while leading the generated image." I'm lost.
@Joonas12334 commented on GitHub (May 21, 2024):
Log file: https://nas.alphabetfilms.eu/sharing/1ihIKjDFP
@sadok-f commented on GitHub (May 22, 2024):
Hi @Joonas12334
Thank you for reporting this issue, I'll investigate it and get back to you asap.
@sadok-f commented on GitHub (May 22, 2024):
Hello @Joonas12334 again,
can you share the full URL parameters that you use when you switch to using
+asoptions_separator?this URL for example works as expected:
upload/rf_1+q_95+w_600/https://picsum.photos/200@Joonas12334 commented on GitHub (May 22, 2024):
I'm using quality and width. For eg i would want to use
https://url/upload/q_70+w_4000/https://url/wp-content/uploads/2024/05/IMGL1271.jpgas i intend to use it as cdn for wordpress then the default "," splits the url rendering link incorrect.@sadok-f commented on GitHub (May 22, 2024):
I can't reproduce the error when using
+asoptions_separator, it works fine for me.however in the log file you shared there is this error
invalid argument for option '-quality' '24,w'which means you still have the old separator,in your URL.@Joonas12334 commented on GitHub (May 22, 2024):
Indeed, it does work when i'm setting the address manually. I guess i was just confused that the flyimg "homepage" stopped working with custom options as that still used "," for the options_seperator.
@sadok-f commented on GitHub (May 23, 2024):
let me check then the homepage code, probably the comma separator is hardcoded within the JS code.
@sadok-f commented on GitHub (May 24, 2024):
Thank you @Joonas12334 for reporting this issue 👍
I've updated the js code to add a new variable called
OPTIONS_SEPARATORinweb/js/main.jsthat needs to be changed when changingoptions_separatorinconfig/parameters.ymlsee PR #451