mirror of
https://github.com/flyimg/flyimg.git
synced 2026-04-25 09:45:50 +03:00
[GH-ISSUE #324] How can we secure our custom hosted Flyimg client on Google Cloud Run #142
Labels
No labels
Docs
Docs
Docs
Security
UnitTest
bug
dependencies
duplicate
enhancement
enhancement
enhancement
hacktoberfest
help wanted
invalid
pull-request
question
stale
version 1
version 2
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/flyimg#142
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @virendrao on GitHub (Dec 2, 2021).
Original GitHub issue: https://github.com/flyimg/flyimg/issues/324
We have hosted Flyimg service on Google Cloud run, all works fine. However we would like say to process request coming only from our domain say abc.net or www.abc.net ?
P.S. I am not talking about image source domain.
@sadok-f commented on GitHub (Dec 2, 2021):
Hi @virendrao,
Many thanks for the issue you opened.
Unfortunately we don't have an implementation to filter the incoming requests.
Maybe you can implement that on the Google Cloud side? I saw a couple of documentation about setting up an external HTTP(S) load balancer in front of Google Cloud Run where you can filter by ip.
@virendrao commented on GitHub (Dec 2, 2021):
Hey thanks buddy. I tried to host it on ElasticBeanStalk as well which worked using steps provided using composer and CLI.
But when I try to put it behind AWS API Gateway as Request Parameter, Gateway basically considers "path separator (/)" which are part of image Source Path as special character I guess and doesn't forward to EB.
Do we have support for Query Parameters ? With Query parameters we should be able to pass HTTP Image Source, rather than Request Parameters.
@sadok-f commented on GitHub (Dec 2, 2021):
Even if you try to encode the image URL parameter?
such as
https%3A%2F%2Fraw.githubusercontent.com%2Fflyimg%2Fgraphic-assets%2Fmaster%2Flogo%2Fraster%2Fflyimg-logo-rgb.png@github-actions[bot] commented on GitHub (Aug 10, 2023):
This issue is stale because it has been open for 30 days with no activity.
@github-actions[bot] commented on GitHub (Aug 25, 2023):
This issue was closed because it has been inactive for 14 days since being marked as stale.
@sadok-f commented on GitHub (Oct 20, 2023):
Hi @virendrao
I'm wondering if you still use Flyimg in your company/organisation ?
If so, it would be great if you could add your entry here in the Adoperts file
https://github.com/flyimg/flyimg/blob/main/ADOPTERS.md
many thanks!