[PR #542] [MERGED] Extended exceptions logic #1169

New issue

Closed

opened 2026-03-15 15:56:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 15:56:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/flyimg/flyimg/pull/542
Author: @VBrilyak
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @sadok-f

Base: main ← Head: feature-exceptions-update

📝 Commits (10+)

4989a94 Initial commit
da5e669 Delete README.md
ce54c3d Merge remote-tracking branch 'gitlab/main'
2add882 Extended exceptions logic
d59a2e7 Merge branch 'main' into feature-exceptions-update
9eb6d97 fixed linting errors
613d950 Merge branch 'feature-exceptions-update' of https://github.com/VBrilyak/flyimg into feature-exceptions-update
aa6b43f update in markup
cc972ca Update in exceptions constructor
19dae6a fix: add UnitTests for the new Exceptions

📊 Changes

32 files changed (+438 additions, -66 deletions)

View changed files

📝 .github/dependabot.yml (+2 -1)
📝 .github/workflows/branch-dev-deploy.yml (+16 -8)
📝 .github/workflows/cd.yml (+22 -6)
📝 .github/workflows/ci.yml (+5 -2)
📝 .github/workflows/close_inactive_issues.yml (+2 -1)
📝 .github/workflows/docs.yml (+2 -1)
📝 composer.json (+1 -0)
📝 composer.lock (+68 -7)
📝 config/parameters.yml (+17 -9)
📝 config/routes.yml (+11 -8)
📝 mkdocs.yml (+12 -11)
📝 phpunit.xml.dist (+1 -1)
📝 src/Core/Entity/Image/InputImage.php (+21 -2)
➕ src/Core/Exception/AccessDeniedException.php (+13 -0)
📝 src/Core/Exception/AppException.php (+8 -1)
📝 src/Core/Exception/ExecFailedException.php (+8 -1)
➕ src/Core/Exception/FileNotFoundException.php (+13 -0)
📝 src/Core/Exception/InvalidArgumentException.php (+7 -1)
📝 src/Core/Exception/MissingParamsException.php (+7 -1)
📝 src/Core/Exception/ReadFileException.php (+7 -1)

...and 12 more files

📄 Description

Hello,
We have a small update regarding the Exceptions logic, which has been adjusted for various scenarios. For example, when 'origin' returns 'File not found', we now return the corresponding Exception based on the HTTP status code (404), etc.
Kind regards

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/flyimg/flyimg/pull/542 **Author:** [@VBrilyak](https://github.com/VBrilyak) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@sadok-f](https://github.com/sadok-f) **Base:** `main` ← **Head:** `feature-exceptions-update` --- ### 📝 Commits (10+) - [`4989a94`](https://github.com/flyimg/flyimg/commit/4989a94c2c0fd97f245db03aae567c275e40be11) Initial commit - [`da5e669`](https://github.com/flyimg/flyimg/commit/da5e6691fa9ca5ceab9ae4c3a26f0debdf2a4e05) Delete README.md - [`ce54c3d`](https://github.com/flyimg/flyimg/commit/ce54c3dcafd944f7ffbac26d3f92870998a56075) Merge remote-tracking branch 'gitlab/main' - [`2add882`](https://github.com/flyimg/flyimg/commit/2add882d64455b580cd6e39b3383df0d5020957d) Extended exceptions logic - [`d59a2e7`](https://github.com/flyimg/flyimg/commit/d59a2e7136bf52e5fba2bff911ed862fbf03bc4f) Merge branch 'main' into feature-exceptions-update - [`9eb6d97`](https://github.com/flyimg/flyimg/commit/9eb6d973057e171f79a6cf81e8268096493a4881) fixed linting errors - [`613d950`](https://github.com/flyimg/flyimg/commit/613d9508cfd3a3ef52bba79e1eb9741800497271) Merge branch 'feature-exceptions-update' of https://github.com/VBrilyak/flyimg into feature-exceptions-update - [`aa6b43f`](https://github.com/flyimg/flyimg/commit/aa6b43f0b954eea29ccec628e27c74dada31510f) update in markup - [`cc972ca`](https://github.com/flyimg/flyimg/commit/cc972cab952b9bb7f7663a1e4dcab5ca343d0fac) Update in exceptions constructor - [`19dae6a`](https://github.com/flyimg/flyimg/commit/19dae6a282d3f26d9853296a4ebb284a360b05ae) fix: add UnitTests for the new Exceptions ### 📊 Changes **32 files changed** (+438 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `.github/dependabot.yml` (+2 -1) 📝 `.github/workflows/branch-dev-deploy.yml` (+16 -8) 📝 `.github/workflows/cd.yml` (+22 -6) 📝 `.github/workflows/ci.yml` (+5 -2) 📝 `.github/workflows/close_inactive_issues.yml` (+2 -1) 📝 `.github/workflows/docs.yml` (+2 -1) 📝 `composer.json` (+1 -0) 📝 `composer.lock` (+68 -7) 📝 `config/parameters.yml` (+17 -9) 📝 `config/routes.yml` (+11 -8) 📝 `mkdocs.yml` (+12 -11) 📝 `phpunit.xml.dist` (+1 -1) 📝 `src/Core/Entity/Image/InputImage.php` (+21 -2) ➕ `src/Core/Exception/AccessDeniedException.php` (+13 -0) 📝 `src/Core/Exception/AppException.php` (+8 -1) 📝 `src/Core/Exception/ExecFailedException.php` (+8 -1) ➕ `src/Core/Exception/FileNotFoundException.php` (+13 -0) 📝 `src/Core/Exception/InvalidArgumentException.php` (+7 -1) 📝 `src/Core/Exception/MissingParamsException.php` (+7 -1) 📝 `src/Core/Exception/ReadFileException.php` (+7 -1) _...and 12 more files_ </details> ### 📄 Description Hello, We have a small update regarding the Exceptions logic, which has been adjusted for various scenarios. For example, when 'origin' returns 'File not found', we now return the corresponding Exception based on the HTTP status code (404), etc. Kind regards --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>