mirror of
https://github.com/floccusaddon/floccus.git
synced 2026-04-25 22:26:06 +03:00
[GH-ISSUE #1426] Merging bookmarks in Firefox behaves like pulling, present bookmarks are deleted #945
Labels
No labels
browser-specific
bug
correctness issues
enhancement
feature: Google Drive
feature: Linkwarden
feature: git
feature: nextcloud-bookmarks
feature: tabs
feature: webdav
help wanted
native-app
priority: high
priority: low
priority: medium
pull-request
question
question
stale
upstream
waiting for more information
wontfix
🙁 Not following issue template
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/floccus#945
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ungive on GitHub (Nov 10, 2023).
Original GitHub issue: https://github.com/floccusaddon/floccus/issues/1426
Which version of floccus are you using?
4.19.1
Sync method
WebDAV
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Firefox 119.0b9 (64-Bit)
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
I have set up my own, very basic WebDAV server with apache2, by following this quick guide:
https://linuxconfig.org/webdav-server-setup-on-ubuntu-linux
My site config
/etc/apache2/sites-available/000-webdav.confcontains:Explanation for the first
Location: I am using Floccus to sync bookmarks between my dual-boot Linux and Windows partition and by using a shared NTFS-drive as backend for my WebDAV server (apache2 for WebDAV on Linux, IIS for WebDAV on Windows). This issue can be reproduced with both, but I made instructions for the apache2 instance. Since it's a shared NTFS drive I had to create a symlink and I figured that might cause some issues, so to be safe I also tested it with anotherLocation, which is just/var/www/webdav/local/with permissions forwww-data:www-data.Describe the Bug
Merging two different sets of bookmarks (those on the server in the bookmarks.xbel file with the ones currently present in the bookmarks bar) causes the local bookmarks to be deleted and replaced with the remote bookmarks, as if the "pull" operation was chosen (but "merge" was used).
Expected Behavior
The sets of bookmarks should be merged, but more importantly, the local bookmarks should never be deleted. Good thing I made a backup first.
To Reproduce
Steps to reproduce:
about:profiles, start it and use it for all the following stepsI didn't attach any logs, since I already deleted my temporary Firefox profile and I'd have to follow all the steps again (I'm lazy) and in case you can reproduce it you could get the logs yourself anyway.
Debug log provided
@github-actions[bot] commented on GitHub (Nov 10, 2023):
Hello 👋
Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.
I look forward to working with you on this issue
Cheers 💙
@ungive commented on GitHub (Nov 10, 2023):
I quickly redid it with fewer bookmarks.
bookmarks-first.xbel:bookmarks-second.xbelMerge result:
Full logs:
@marcelklehr commented on GitHub (Nov 14, 2023):
Hello @jonasberge
Thank you for opening this issue. However, I have to tell you that I believe your assumptions are wrong. The "Merge" strategy is not stateless. It may be stateless initially, but it is not stateless on consecutive runs, for the following reasons:
Floccus keeps track of bookmarks IDs in order to account for movements of bookmarks between folders. Unless you clear floccus' cache in your account settings, floccus will assume that all local bookmarks have been removed if it cannot find their IDs in the XBEL file anymore. You cannot simply switch out the XBEL file and expect things to just work. At the very least you will have to clear the local cache, but even then I don't recommend switching out the XBEL file.
Floccus should have a failsafe to avoid deleting more than 50% of local bookmarks, though.
@github-actions[bot] commented on GitHub (Nov 14, 2024):
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.